components/password_manager/core/browser/BUILD.gn - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: address nparker's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/BUILD.gn

diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn

index 056d7d6164c186d66ed77897f6d61146e9157b55..30a155503dfa96269fa184d51860a72d50b886d0 100644

--- a/components/password_manager/core/browser/BUILD.gn

+++ b/components/password_manager/core/browser/BUILD.gn

@@ -189,10 +189,6 @@ static_library("browser") {

sources -= [ "login_database_posix.cc" ]

}

- if (!is_ios) {

- deps += [ "//components/safe_browsing/password_protection" ]

- }

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

}