components/password_manager/core/browser/password_reuse_detector_unittest.cc - Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detector_unittest.cc

Issue 2912383004: Fill is_chrome_signin_password field in the password entry pings. (Closed)

Patch Set: address nparker's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_reuse_detector_consumer.h ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detector_unittest.cc

diff --git a/components/password_manager/core/browser/password_reuse_detector_unittest.cc b/components/password_manager/core/browser/password_reuse_detector_unittest.cc

index 94d2fa82665967e353f11145145f646ddc411f54..2f45d16d099c4c435e2c2ed4732d0ba7f081da0a 100644

--- a/components/password_manager/core/browser/password_reuse_detector_unittest.cc

+++ b/components/password_manager/core/browser/password_reuse_detector_unittest.cc

@@ -209,8 +209,9 @@ TEST(PasswordReuseDetectorTest, SyncPasswordReuseFound) {

reuse_detector.SaveSyncPasswordHash(ASCIIToUTF16("sync_password"));

- EXPECT_CALL(mockConsumer, OnReuseFound(ASCIIToUTF16("sync_password"),

- "accounts.google.com", 1, 0));

+ EXPECT_CALL(mockConsumer,

+ OnReuseFound(ASCIIToUTF16("sync_password"),

+ std::string(kSyncPasswordDomain), 1, 0));

reuse_detector.CheckReuse(ASCIIToUTF16("sync_password"), "https://evil.com",

&mockConsumer);

}