Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2908793002: [mus+ash] Removes WmWindow from ash/wm/overview and ash/wm/workspace (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash/wm/overview and ash/wm/workspace BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2908793002 Cr-Commit-Position: refs/heads/master@{#475096} Committed: https://chromium.googlesource.com/chromium/src/+/ae5decc21d826351ebb953cab11c0014ea35585d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -157 lines) Patch
M ash/aura/shell_port_classic.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/aura/shell_port_classic.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/bridge/shell_port_mash.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/shell_port_mash.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_port.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/overview/cleanup_animation_observer_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/tablet_mode/tablet_mode_event_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/tablet_mode/tablet_mode_window_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_util.h View 2 chunks +18 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M ash/wm/workspace/backdrop_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_aura.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_aura.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm_window.h View 3 chunks +0 lines, -15 lines 0 comments Download
M ash/wm_window.cc View 2 chunks +0 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
varkha
sky@, can you please take a look at the next installment? I think the only ...
3 years, 7 months ago (2017-05-26 18:07:51 UTC) #4
sky
LGTM
3 years, 7 months ago (2017-05-26 19:10:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908793002/1
3 years, 7 months ago (2017-05-26 19:44:08 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 20:05:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae5decc21d826351ebb953cab11c...

Powered by Google App Engine
This is Rietveld 408576698