Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2904273002: [mus+ash] Removes WmWindow from RootWindowcontroller implementation (Closed)

Created:
3 years, 6 months ago by varkha
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash RootWindowcontroller implementation Moves WmWindow methods SetChildrenUseExtendedHitRegion and ShouldUseExtendedHitRegion into window_util (as SetChildrenUseExtendedHitRegionForWindow and ShouldUseExtendedHitRegionForWindow) and adds kChildrenUseExtendedHitRegion bool property that can be set on a container to use an easy targeter. BUG=687656 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2904273002 Cr-Commit-Position: refs/heads/master@{#475181} Committed: https://chromium.googlesource.com/chromium/src/+/515b434684c2225f869b1bfe2a477d5cd479d005

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from RootWindowcontroller implementation (rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -161 lines) Patch
M ash/mus/non_client_frame_controller.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 8 chunks +96 lines, -111 lines 0 comments Download
M ash/shelf/shelf_window_targeter.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/shelf/shelf_window_targeter.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ash/wm/window_properties.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/window_properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M ash/wm_window.h View 3 chunks +0 lines, -10 lines 0 comments Download
M ash/wm_window.cc View 2 chunks +0 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
varkha
sky@, please take a look, this is probably the last one for this week. Thanks!
3 years, 6 months ago (2017-05-26 20:08:22 UTC) #2
sky
LGTM
3 years, 6 months ago (2017-05-26 22:59:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904273002/20001
3 years, 6 months ago (2017-05-26 23:16:07 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 23:21:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/515b434684c2225f869b1bfe2a47...

Powered by Google App Engine
This is Rietveld 408576698