Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2901413005: [mus+ash] Removes WmWindow from ash/accelerators (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash/accelerators BUG=726799 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2901413005 Cr-Commit-Position: refs/heads/master@{#475130} Committed: https://chromium.googlesource.com/chromium/src/+/157a42ed89f0c1707620aa649fa0844b8c572bcc

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from ash/accelerators (rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/accelerators/accelerator_router.h View 3 chunks +7 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_router.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_registrar.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
varkha
sky@, can you please take a look? Thanks!
3 years, 7 months ago (2017-05-26 18:57:50 UTC) #2
sky
LGTM
3 years, 7 months ago (2017-05-26 19:11:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901413005/20001
3 years, 7 months ago (2017-05-26 21:11:34 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 21:17:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/157a42ed89f0c1707620aa649fa0...

Powered by Google App Engine
This is Rietveld 408576698