Get and return String by const-ref if used as rvalue

Get and return String by const-ref if used as rvalue

Generated bindings return String attributes by value instead of const reference.
This leads to uneccesary copies and can lead to confusing runtime behavior when
a getter is used as a setter by accident. This change addresses this by changing
'String' to 'const String&' where appropriate, which addresses both of these
issues.

BUG=NONE

Review-Url: https://codereview.chromium.org/2897603003
Cr-Commit-Position: refs/heads/master@{#473192}
Committed: https://chromium.googlesource.com/chromium/src/+/3fb17e012c431c830c857bdd9e350603137d11b3

[jdoerrie, 2017-05-19 11:06:00]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 11:06:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-05-19 11:09:55]

Description was changed from

==========
Get and return String by const-ref if used as rvalue

BUG=NONE
==========

to

==========
Get and return String by const-ref if used as rvalue

Generated bindings return String attributes by value instead of const reference.
This leads to uneccesary copies and can lead to confusing runtime behavior when
a getter is used as a setter by accident. This change addresses this by changing
'String' to 'const String&' where appropriate, which addresses both of these
issues.

BUG=NONE
==========

[jdoerrie, 2017-05-19 11:09:55]

jdoerrie@chromium.org changed reviewers:
+ mkwst@chromium.org

[jdoerrie, 2017-05-19 11:11:08]

Hi Mike, please review :)

[commit-bot: I haz the power, 2017-05-19 13:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:10:00]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-05-19 14:06:40]

LGTM

[jdoerrie, 2017-05-19 15:08:01]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-05-19 15:08:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 15:14:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495206481295170, "parent_rev":
"5f5f9f2b3594be526f6253e054e7fa7da7405b24", "commit_rev":
"3fb17e012c431c830c857bdd9e350603137d11b3"}

[commit-bot: I haz the power, 2017-05-19 15:14:41]

Description was changed from

==========
Get and return String by const-ref if used as rvalue

Generated bindings return String attributes by value instead of const reference.
This leads to uneccesary copies and can lead to confusing runtime behavior when
a getter is used as a setter by accident. This change addresses this by changing
'String' to 'const String&' where appropriate, which addresses both of these
issues.

BUG=NONE
==========

to

==========
Get and return String by const-ref if used as rvalue

Generated bindings return String attributes by value instead of const reference.
This leads to uneccesary copies and can lead to confusing runtime behavior when
a getter is used as a setter by accident. This change addresses this by changing
'String' to 'const String&' where appropriate, which addresses both of these
issues.

BUG=NONE

Review-Url: https://codereview.chromium.org/2897603003
Cr-Commit-Position: refs/heads/master@{#473192}
Committed:
https://chromium.googlesource.com/chromium/src/+/3fb17e012c431c830c857bdd9e35...
==========

[commit-bot: I haz the power, 2017-05-19 15:14:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fb17e012c431c830c857bdd9e35...

[Mike West, 2017-05-19 15:24:06]

mkwst@chromium.org changed reviewers:
+ haraken@chromium.org

[Mike West, 2017-05-19 15:24:06]

LGTM 2! Even though I didn't see it until 8 minutes after it landed. :)