third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h - Issue 2897603003: Get and return String by const-ref if used as rvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h b/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h

index 06339aa6119e47016952ed521781771a647a548e..b3595736fe38bf367b21eeb60a76fa6f1f8f3a09 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h

@@ -33,9 +33,9 @@ class CORE_EXPORT BooleanOrStringOrUnrestrictedDouble final {

static BooleanOrStringOrUnrestrictedDouble fromBoolean(bool);

bool isString() const { return m_type == SpecificTypeString; }

- String getAsString() const;

- void setString(String);

- static BooleanOrStringOrUnrestrictedDouble fromString(String);

+ const String& getAsString() const;

+ void setString(const String&);

+ static BooleanOrStringOrUnrestrictedDouble fromString(const String&);

bool isUnrestrictedDouble() const { return m_type == SpecificTypeUnrestrictedDouble; }

double getAsUnrestrictedDouble() const;