third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp - Issue 2897603003: Get and return String by const-ref if used as rvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

index 8113eb61a206f4461f17e7e8bd7bb7b769ea5338..2b097dd665e92c196c7beb7e469b65d7289907e6 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

@@ -36,12 +36,12 @@ TestEnumOrDouble TestEnumOrDouble::fromDouble(double value) {

return container;

}

-String TestEnumOrDouble::getAsTestEnum() const {

+const String& TestEnumOrDouble::getAsTestEnum() const {

DCHECK(isTestEnum());

return m_testEnum;

}

-void TestEnumOrDouble::setTestEnum(String value) {

+void TestEnumOrDouble::setTestEnum(const String& value) {

DCHECK(isNull());

NonThrowableExceptionState exceptionState;

const char* validValues[] = {

@@ -58,7 +58,7 @@ void TestEnumOrDouble::setTestEnum(String value) {

m_type = SpecificTypeTestEnum;

}

-TestEnumOrDouble TestEnumOrDouble::fromTestEnum(String value) {

+TestEnumOrDouble TestEnumOrDouble::fromTestEnum(const String& value) {

TestEnumOrDouble container;

container.setTestEnum(value);

return container;