Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
index cb1ac695579612a2bb0d1f482752a5eb9e44697a..fa7ed400f24f1227f5cbd7e9bdd64a98d2573b30 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp
@@ -26,19 +26,19 @@ TestDictionaryDerivedImplementedAs& TestDictionaryDerivedImplementedAs::operator
bool TestDictionaryDerivedImplementedAs::hasDerivedStringMember() const {
return !m_derivedStringMember.IsNull();
}
-String TestDictionaryDerivedImplementedAs::derivedStringMember() const {
+const String& TestDictionaryDerivedImplementedAs::derivedStringMember() const {
return m_derivedStringMember;
}
-void TestDictionaryDerivedImplementedAs::setDerivedStringMember(String value) {
+void TestDictionaryDerivedImplementedAs::setDerivedStringMember(const String& value) {
m_derivedStringMember = value;
}
bool TestDictionaryDerivedImplementedAs::hasDerivedStringMemberWithDefault() const {
return !m_derivedStringMemberWithDefault.IsNull();
}
-String TestDictionaryDerivedImplementedAs::derivedStringMemberWithDefault() const {
+const String& TestDictionaryDerivedImplementedAs::derivedStringMemberWithDefault() const {
return m_derivedStringMemberWithDefault;
}
-void TestDictionaryDerivedImplementedAs::setDerivedStringMemberWithDefault(String value) {
+void TestDictionaryDerivedImplementedAs::setDerivedStringMemberWithDefault(const String& value) {
m_derivedStringMemberWithDefault = value;
}
bool TestDictionaryDerivedImplementedAs::hasRequiredLongMember() const {

Powered by Google App Engine
This is Rietveld 408576698