Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
index 6d96d38bc32a48f07fa2b048687c2ead3ecc01c8..babca4752fac0d1bccb9ef915d70223ce7e5e6eb 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp
@@ -139,10 +139,10 @@ void TestDictionary::setElementOrNullMemberToNull() {
bool TestDictionary::hasEnumMember() const {
return !m_enumMember.IsNull();
}
-String TestDictionary::enumMember() const {
+const String& TestDictionary::enumMember() const {
return m_enumMember;
}
-void TestDictionary::setEnumMember(String value) {
+void TestDictionary::setEnumMember(const String& value) {
m_enumMember = value;
}
bool TestDictionary::hasEnumSequenceMember() const {
@@ -284,19 +284,19 @@ void TestDictionary::setStringArrayMember(const Vector<String>& value) {
bool TestDictionary::hasStringMember() const {
return !m_stringMember.IsNull();
}
-String TestDictionary::stringMember() const {
+const String& TestDictionary::stringMember() const {
return m_stringMember;
}
-void TestDictionary::setStringMember(String value) {
+void TestDictionary::setStringMember(const String& value) {
m_stringMember = value;
}
bool TestDictionary::hasStringOrNullMember() const {
return !m_stringOrNullMember.IsNull();
}
-String TestDictionary::stringOrNullMember() const {
+const String& TestDictionary::stringOrNullMember() const {
return m_stringOrNullMember;
}
-void TestDictionary::setStringOrNullMember(String value) {
+void TestDictionary::setStringOrNullMember(const String& value) {
m_stringOrNullMember = value;
}
void TestDictionary::setStringOrNullMemberToNull() {

Powered by Google App Engine
This is Rietveld 408576698