Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
index 58166c537bf5fb3acaf0e46ba51fbd391a49d827..d31735546fc83566a6a46686d1e9a1e386b3abe4 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
@@ -83,8 +83,8 @@ class CORE_EXPORT TestDictionary : public IDLDictionaryBase {
void setElementOrNullMemberToNull();
bool hasEnumMember() const;
- String enumMember() const;
- void setEnumMember(String);
+ const String& enumMember() const;
+ void setEnumMember(const String&);
bool hasEnumSequenceMember() const;
const Vector<String>& enumSequenceMember() const;
@@ -140,12 +140,12 @@ class CORE_EXPORT TestDictionary : public IDLDictionaryBase {
void setStringArrayMember(const Vector<String>&);
bool hasStringMember() const;
- String stringMember() const;
- void setStringMember(String);
+ const String& stringMember() const;
+ void setStringMember(const String&);
bool hasStringOrNullMember() const;
- String stringOrNullMember() const;
- void setStringOrNullMember(String);
+ const String& stringOrNullMember() const;
+ void setStringOrNullMember(const String&);
void setStringOrNullMemberToNull();
bool hasStringSequenceMember() const;

Powered by Google App Engine
This is Rietveld 408576698