third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2897603003: Get and return String by const-ref if used as rvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2897603003: Get and return String by const-ref if used as rvalue (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 121779c8e03990b59f938dd13e26cedbbe985233..aa23c402ca828d8f11a73963ebb78d2666deab3e 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -201,7 +201,7 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_rvalue_

return ('PassRefPtr<%s>' if used_as_rvalue_type else 'RefPtr<%s>') % base_idl_type

if idl_type.is_string_type:

if not raw_type:

- return 'String'

+ return 'const String&' if used_as_rvalue_type else 'String'

return 'V8StringResource<%s>' % string_mode()

if base_idl_type == 'ArrayBufferView' and 'FlexibleArrayBufferView' in extended_attributes:

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h » ('j') | no next file with comments »