Rename requireUserMediation to preventSilentAccess in the CM API.

Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec: https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG=724464
NOTRY=true

Review-Url: https://codereview.chromium.org/2895243002
Cr-Commit-Position: refs/heads/master@{#474640}
Committed: https://chromium.googlesource.com/chromium/src/+/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d

[vasilii, 2017-05-22 14:03:28]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 14:03:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 15:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 15:26:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vasilii, 2017-05-23 09:42:46]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:43:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-05-23 09:45:11]

vasilii@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[vasilii, 2017-05-23 09:45:12]

Hi all,

please review the CL. Jochen, we need a 3rd LGTM for landing this patch.

[jochen (gone - plz use gerrit), 2017-05-23 11:07:56]

you'll also need to get the PR merged before landing the patch.

do layout tests actually pass with this CL? I'm surprised requireUserMediation
doesn't show up anymore in the global interface listing?

https://codereview.chromium.org/2895243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2895243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1605:
kCredentialManagerRequireUserMediation = 1994,
please keep the old name for 964, and use the new counter for the new name

[commit-bot: I haz the power, 2017-05-23 11:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 11:59:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2017-05-23 12:31:30]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 12:32:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-05-23 12:34:19]

It was a mistake to remove requireUserMediation. Now the failing tests are
passing locally.

https://codereview.chromium.org/2895243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2895243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1605:
kCredentialManagerRequireUserMediation = 1994,
On 2017/05/23 11:07:56, jochen wrote:
> please keep the old name for 964, and use the new counter for the new name

Done.

[commit-bot: I haz the power, 2017-05-23 15:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:53:34]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-05-23 18:54:33]

https://codereview.chromium.org/2895243002/diff/40001/components/password_man...
File components/password_manager/content/common/credential_manager.mojom
(right):

https://codereview.chromium.org/2895243002/diff/40001/components/password_man...
components/password_manager/content/common/credential_manager.mojom:43: //
Require user mediation. For navigator.credentials.requireUserMediation().
Nit: Replace here too.

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html
(right):

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html:1:
<!DOCTYPE html>
Nit: Can you copy this test so that we keep some coverage for
`requireUserMediation()`?

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html:7:
assert_equals(c, undefined, "FIXME: We're currently always returning
'undefined'.");
Nit: Drop the FIXME. This is the behavior we settled on.

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:432: milestoneString(M62));
Nit: I'd suggest something like:

```
return replacedWillBeRemoved(
    "The CredentialsContainer.requireUserMediation method",
    "the CredentialsContainer.preventSilentAccess method",
    M62,
    "4781762488041472");
```

[vasilii, 2017-05-24 10:02:07]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[vasilii, 2017-05-24 10:02:13]

https://codereview.chromium.org/2895243002/diff/40001/components/password_man...
File components/password_manager/content/common/credential_manager.mojom
(right):

https://codereview.chromium.org/2895243002/diff/40001/components/password_man...
components/password_manager/content/common/credential_manager.mojom:43: //
Require user mediation. For navigator.credentials.requireUserMediation().
On 2017/05/23 18:54:32, Mike West wrote:
> Nit: Replace here too.

Done.

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html
(right):

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html:1:
<!DOCTYPE html>
On 2017/05/23 18:54:32, Mike West wrote:
> Nit: Can you copy this test so that we keep some coverage for
> `requireUserMediation()`?

Done.

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-requireusermediation-basics.html:7:
assert_equals(c, undefined, "FIXME: We're currently always returning
'undefined'.");
On 2017/05/23 18:54:32, Mike West wrote:
> Nit: Drop the FIXME. This is the behavior we settled on.

Done.

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2895243002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:432: milestoneString(M62));
On 2017/05/23 18:54:32, Mike West wrote:
> Nit: I'd suggest something like:
> 
> ```
> return replacedWillBeRemoved(
>     "The CredentialsContainer.requireUserMediation method",
>     "the CredentialsContainer.preventSilentAccess method",
>     M62,
>     "4781762488041472");
> ```

Done.

[commit-bot: I haz the power, 2017-05-24 10:02:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 10:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 10:05:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2017-05-24 11:11:09]

mkwst@chromium.org changed required reviewers:
+ jochen@chromium.org

[Mike West, 2017-05-24 11:11:10]

LGTM, pending Jochen's review, here and on blink-dev@.

[vasilii, 2017-05-24 11:12:46]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 11:13:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-05-24 12:37:45]

Jochen, the spec changes have landed.

[commit-bot: I haz the power, 2017-05-24 12:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 12:39:49]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jochen (gone - plz use gerrit), 2017-05-24 15:10:02]

lgtm once the intent is approved

[vasilii, 2017-05-24 17:59:55]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 18:00:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:58:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:58:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vasilii, 2017-05-25 09:50:23]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2017-05-25 09:50:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2895243002/#ps120001
(title: "merge")

[commit-bot: I haz the power, 2017-05-25 09:50:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 13:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:05:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2017-05-25 13:10:10]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:10:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-05-25 13:52:41]

Description was changed from

==========
Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec:
https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG=724464
==========

to

==========
Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec:
https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG=724464
NOTRY=true
==========

[vasilii, 2017-05-25 13:52:51]

The CQ bit was unchecked by vasilii@chromium.org

[vasilii, 2017-05-25 13:53:08]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2017-05-25 13:53:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 13:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495720388434880,
"parent_rev": "a23b4bac4b5965383eb17f8c9942ac40e58fdf3e", "commit_rev":
"2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d"}

[commit-bot: I haz the power, 2017-05-25 13:59:34]

Description was changed from

==========
Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec:
https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG=724464
NOTRY=true
==========

to

==========
Rename requireUserMediation to preventSilentAccess in the CM API.

Pull request for the spec:
https://github.com/w3c/webappsec-credential-management/pull/84
Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TZ1wr5BJ0Uk

BUG=724464
NOTRY=true

Review-Url: https://codereview.chromium.org/2895243002
Cr-Commit-Position: refs/heads/master@{#474640}
Committed:
https://chromium.googlesource.com/chromium/src/+/2118f8bacddd5504dbea6a2906f2...
==========

[commit-bot: I haz the power, 2017-05-25 13:59:36]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/2118f8bacddd5504dbea6a2906f2...