components/password_manager/content/renderer/credential_manager_client.cc - Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)

Patch Set: merge Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client.h ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index b310d0921bec2b8c23ab4cecf76f2d1813da9a69..1111e03a58dca3567e43b7e77d87c41a393d0597 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -231,12 +231,12 @@ void CredentialManagerClient::DispatchStore(

base::Owned(new NotificationCallbacksWrapper(callbacks))));

}

-void CredentialManagerClient::DispatchRequireUserMediation(

+void CredentialManagerClient::DispatchPreventSilentAccess(

blink::WebCredentialManagerClient::NotificationCallbacks* callbacks) {

DCHECK(callbacks);

ConnectToMojoCMIfNeeded();

- mojo_cm_service_->RequireUserMediation(

+ mojo_cm_service_->PreventSilentAccess(

base::Bind(&RespondToNotificationCallback,

base::Owned(new NotificationCallbacksWrapper(callbacks))));

}