Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)
Patch Set: webkit tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 case UseCounter::kCredentialManagerAdditionalData: 418 case UseCounter::kCredentialManagerAdditionalData:
419 case UseCounter::kCredentialManagerCustomFetch: 419 case UseCounter::kCredentialManagerCustomFetch:
420 return String::Format( 420 return String::Format(
421 "Passing 'PasswordCredential' objects into 'fetch(..., { " 421 "Passing 'PasswordCredential' objects into 'fetch(..., { "
422 "credentials: ... })' is deprecated, and will be removed in %s. See " 422 "credentials: ... })' is deprecated, and will be removed in %s. See "
423 "https://www.chromestatus.com/features/5689327799500800 for more " 423 "https://www.chromestatus.com/features/5689327799500800 for more "
424 "details and https://www.chromium.org/developers/" 424 "details and https://www.chromium.org/developers/"
425 "recent-changes-credential-management-api for migration suggestions.", 425 "recent-changes-credential-management-api for migration suggestions.",
426 milestoneString(M62)); 426 milestoneString(M62));
427 427
428 case UseCounter::kCredentialManagerRequireUserMediation:
429 return String::Format(
430 "'requireUserMediation' was renamed to 'preventSilentAccess'. The "
431 "method will be removed in %s.",
432 milestoneString(M62));
Mike West 2017/05/23 18:54:32 Nit: I'd suggest something like: ``` return repla
vasilii 2017/05/24 10:02:13 Done.
433
428 // Features that aren't deprecated don't have a deprecation message. 434 // Features that aren't deprecated don't have a deprecation message.
429 default: 435 default:
430 return String(); 436 return String();
431 } 437 }
432 } 438 }
433 439
434 } // namespace blink 440 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698