Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)
Patch Set: merge Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_impl.cc
diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc
index 9b5db4c65ffe5886dacc3e71e57ef606be750935..608ccbb578683e5f3e4498784ea684e7ce1f02e3 100644
--- a/components/password_manager/content/browser/credential_manager_impl.cc
+++ b/components/password_manager/content/browser/credential_manager_impl.cc
@@ -126,11 +126,11 @@ void CredentialManagerImpl::OnProvisionalSaveComplete() {
client_->PromptUserToSaveOrUpdatePassword(std::move(form_manager_), false);
}
-void CredentialManagerImpl::RequireUserMediation(
- RequireUserMediationCallback callback) {
+void CredentialManagerImpl::PreventSilentAccess(
+ PreventSilentAccessCallback callback) {
if (password_manager_util::IsLoggingActive(client_)) {
CredentialManagerLogger(client_->GetLogManager())
- .LogRequireUserMediation(web_contents()->GetLastCommittedURL());
+ .LogPreventSilentAccess(web_contents()->GetLastCommittedURL());
}
// Send acknowledge response back.
std::move(callback).Run();
@@ -142,7 +142,7 @@ void CredentialManagerImpl::RequireUserMediation(
if (!pending_require_user_mediation_) {
pending_require_user_mediation_.reset(
- new CredentialManagerPendingRequireUserMediationTask(this));
+ new CredentialManagerPendingPreventSilentAccessTask(this));
}
pending_require_user_mediation_->AddOrigin(GetSynthesizedFormForOrigin());
}

Powered by Google App Engine
This is Rietveld 408576698