components/password_manager/core/browser/credential_manager_logger_unittest.cc - Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_logger_unittest.cc

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)

Patch Set: merge Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_logger.cc ('k') | components/password_manager/core/browser/credential_manager_pending_prevent_silent_access_task.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_logger_unittest.cc

diff --git a/components/password_manager/core/browser/credential_manager_logger_unittest.cc b/components/password_manager/core/browser/credential_manager_logger_unittest.cc

index fb6baaf251f3bc7224813cb1aaa1a193b0703cd4..74e31a547f502659940ae67f382f7c9e705cf885 100644

--- a/components/password_manager/core/browser/credential_manager_logger_unittest.cc

+++ b/components/password_manager/core/browser/credential_manager_logger_unittest.cc

@@ -70,9 +70,9 @@ TEST_F(CredentialManagerLoggerTest, LogStoreCredential) {

CredentialType::CREDENTIAL_TYPE_PASSWORD);

}

-TEST_F(CredentialManagerLoggerTest, LogRequireUserMediation) {

+TEST_F(CredentialManagerLoggerTest, LogPreventSilentAccess) {

EXPECT_CALL(log_manager(), LogSavePasswordProgress(HasSubstr(kSiteOrigin)));

- logger().LogRequireUserMediation(GURL(kSiteOrigin));

+ logger().LogPreventSilentAccess(GURL(kSiteOrigin));

}

} // namespace