Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.h

Issue 2895243002: Rename requireUserMediation to preventSilentAccess in the CM API. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 kV8Window_RequestIdleCallback_Method = 954, 701 kV8Window_RequestIdleCallback_Method = 954,
702 kFlexboxPercentagePaddingVertical = 955, 702 kFlexboxPercentagePaddingVertical = 955,
703 kFlexboxPercentageMarginVertical = 956, 703 kFlexboxPercentageMarginVertical = 956,
704 kBackspaceNavigatedBack = 957, 704 kBackspaceNavigatedBack = 957,
705 kBackspaceNavigatedBackAfterFormInteraction = 958, 705 kBackspaceNavigatedBackAfterFormInteraction = 958,
706 kCSPSourceWildcardWouldMatchExactHost = 959, 706 kCSPSourceWildcardWouldMatchExactHost = 959,
707 kCredentialManagerGet = 960, 707 kCredentialManagerGet = 960,
708 kCredentialManagerGetMediationOptional = 961, 708 kCredentialManagerGetMediationOptional = 961,
709 kCredentialManagerGetMediationSilent = 962, 709 kCredentialManagerGetMediationSilent = 962,
710 kCredentialManagerStore = 963, 710 kCredentialManagerStore = 963,
711 kCredentialManagerRequireUserMediation = 964, 711 kCredentialManagerPreventSilentAccess = 964,
712 // The above items are available in M47 branch. 712 // The above items are available in M47 branch.
713 713
714 kBlockableMixedContentInSubframeBlocked = 966, 714 kBlockableMixedContentInSubframeBlocked = 966,
715 kAddEventListenerThirdArgumentIsObject = 967, 715 kAddEventListenerThirdArgumentIsObject = 967,
716 kRemoveEventListenerThirdArgumentIsObject = 968, 716 kRemoveEventListenerThirdArgumentIsObject = 968,
717 kCSSAtRuleCharset = 969, 717 kCSSAtRuleCharset = 969,
718 kCSSAtRuleFontFace = 970, 718 kCSSAtRuleFontFace = 970,
719 kCSSAtRuleImport = 971, 719 kCSSAtRuleImport = 971,
720 kCSSAtRuleKeyframes = 972, 720 kCSSAtRuleKeyframes = 972,
721 kCSSAtRuleMedia = 973, 721 kCSSAtRuleMedia = 973,
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 kCredentialManagerGetMediationRequired = 1984, 1595 kCredentialManagerGetMediationRequired = 1984,
1596 kCredentialManagerIdName = 1985, 1596 kCredentialManagerIdName = 1985,
1597 kCredentialManagerPasswordName = 1986, 1597 kCredentialManagerPasswordName = 1986,
1598 kCredentialManagerAdditionalData = 1987, 1598 kCredentialManagerAdditionalData = 1987,
1599 kCredentialManagerCustomFetch = 1988, 1599 kCredentialManagerCustomFetch = 1988,
1600 kNetInfoRtt = 1989, 1600 kNetInfoRtt = 1989,
1601 kNetInfoDownlink = 1990, 1601 kNetInfoDownlink = 1990,
1602 kShapeDetection_BarcodeDetectorConstructor = 1991, 1602 kShapeDetection_BarcodeDetectorConstructor = 1991,
1603 kShapeDetection_FaceDetectorConstructor = 1992, 1603 kShapeDetection_FaceDetectorConstructor = 1992,
1604 kShapeDetection_TextDetectorConstructor = 1993, 1604 kShapeDetection_TextDetectorConstructor = 1993,
1605 kCredentialManagerRequireUserMediation = 1994,
jochen (gone - plz use gerrit) 2017/05/23 11:07:56 please keep the old name for 964, and use the new
vasilii 2017/05/23 12:34:19 Done.
1605 1606
1606 // Add new features immediately above this line. Don't change assigned 1607 // Add new features immediately above this line. Don't change assigned
1607 // numbers of any item, and don't reuse removed slots. 1608 // numbers of any item, and don't reuse removed slots.
1608 // Also, run update_use_counter_feature_enum.py in 1609 // Also, run update_use_counter_feature_enum.py in
1609 // chromium/src/tools/metrics/histograms/ to update the UMA mapping. 1610 // chromium/src/tools/metrics/histograms/ to update the UMA mapping.
1610 kNumberOfFeatures, // This enum value must be last. 1611 kNumberOfFeatures, // This enum value must be last.
1611 }; 1612 };
1612 1613
1613 // An interface to observe UseCounter changes. Note that this is never 1614 // An interface to observe UseCounter changes. Note that this is never
1614 // notified when the counter is disabled by |m_muteCount| or when |m_context| 1615 // notified when the counter is disabled by |m_muteCount| or when |m_context|
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
1712 // Tracks what features/properties need to be reported to the legacy 1713 // Tracks what features/properties need to be reported to the legacy
1713 // histograms. 1714 // histograms.
1714 BitVector feature_bits_; 1715 BitVector feature_bits_;
1715 BitVector css_bits_; 1716 BitVector css_bits_;
1716 } legacy_counter_; 1717 } legacy_counter_;
1717 }; 1718 };
1718 1719
1719 } // namespace blink 1720 } // namespace blink
1720 1721
1721 #endif // UseCounter_h 1722 #endif // UseCounter_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698