Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed (Closed)

Created:
3 years, 7 months ago by jkarlin
Modified:
3 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[PageLoadMetrics] Don't record an ads histogram if the page hasn't committed This is a simple fix with a complex test. BUG=723219, 708570 Review-Url: https://codereview.chromium.org/2893633003 Cr-Commit-Position: refs/heads/master@{#472833} Committed: https://chromium.googlesource.com/chromium/src/+/40c27d78b91fc87eb549e263640e66d8a3f4ba67

Patch Set 1 #

Patch Set 2 : Move function #

Total comments: 12

Patch Set 3 : Address comments from PS2 #

Messages

Total messages: 21 (14 generated)
jkarlin
csharrison@ PTAL, thanks!
3 years, 7 months ago (2017-05-17 18:27:41 UTC) #3
Charlie Harrison
Generally looks good just a few comments https://codereview.chromium.org/2893633003/diff/20001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc File chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc (right): https://codereview.chromium.org/2893633003/diff/20001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc#newcode44 chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc:44: // Delays ...
3 years, 7 months ago (2017-05-17 18:54:51 UTC) #8
jkarlin
PTAL, thanks! https://codereview.chromium.org/2893633003/diff/20001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc File chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc (right): https://codereview.chromium.org/2893633003/diff/20001/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc#newcode44 chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc:44: // Delays WillProcessResponse until the caller tells ...
3 years, 7 months ago (2017-05-18 13:50:14 UTC) #12
Charlie Harrison
LGTM
3 years, 7 months ago (2017-05-18 14:56:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893633003/40001
3 years, 7 months ago (2017-05-18 14:56:54 UTC) #17
jkarlin
Thanks!
3 years, 7 months ago (2017-05-18 14:56:56 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 16:17:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/40c27d78b91fc87eb549e263640e...

Powered by Google App Engine
This is Rietveld 408576698