Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed (Closed)
Patch Set: Address comments from PS2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSERVE R_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 std::map<FrameTreeNodeId, AdFrameData*> ad_frames_data_; 66 std::map<FrameTreeNodeId, AdFrameData*> ad_frames_data_;
67 67
68 // When the observer receives report of a document resource loading for a 68 // When the observer receives report of a document resource loading for a
69 // sub-frame before the sub-frame commit occurs, hold onto the resource 69 // sub-frame before the sub-frame commit occurs, hold onto the resource
70 // request info (delay it) until the sub-frame commits. 70 // request info (delay it) until the sub-frame commits.
71 std::map<FrameTreeNodeId, page_load_metrics::ExtraRequestCompleteInfo> 71 std::map<FrameTreeNodeId, page_load_metrics::ExtraRequestCompleteInfo>
72 ongoing_navigation_resources_; 72 ongoing_navigation_resources_;
73 73
74 size_t page_bytes_ = 0u; 74 size_t page_bytes_ = 0u;
75 size_t uncached_page_bytes_ = 0u; 75 size_t uncached_page_bytes_ = 0u;
76 bool committed_ = false;
76 77
77 DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserver); 78 DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserver);
78 }; 79 };
79 80
80 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSE RVER_H_ 81 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ADS_PAGE_LOAD_METRICS_OBSE RVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698