chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h - Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed (Closed)

Patch Set: Address comments from PS2 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

index af156579b7750d92db0c107e8b73b3b604dd551b..4ab9fd05c9c85019d6a82786b3de63540d11635f 100644

--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h

@@ -73,6 +73,7 @@ class AdsPageLoadMetricsObserver

size_t page_bytes_ = 0u;

size_t uncached_page_bytes_ = 0u;

+ bool committed_ = false;

DISALLOW_COPY_AND_ASSIGN(AdsPageLoadMetricsObserver);

};

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc » ('j') | no next file with comments »