Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2889933003: [PageLoadMetrics] Enable AdsPageLoadMetrics once again (Closed)

Created:
3 years, 7 months ago by jkarlin
Modified:
3 years, 7 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 Review-Url: https://codereview.chromium.org/2889933003 Cr-Commit-Position: refs/heads/master@{#472866} Committed: https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
jkarlin
bmcquade@ PTAL, the fix is in https://codereview.chromium.org/2893633003/ and this patch depends on it.
3 years, 7 months ago (2017-05-17 18:35:57 UTC) #5
Bryan McQuade
lgtm
3 years, 7 months ago (2017-05-17 22:07:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889933003/20001
3 years, 7 months ago (2017-05-18 16:46:46 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:49:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8...

Powered by Google App Engine
This is Rietveld 408576698