[PageLoadMetrics] Don't record an ads histogram if the page hasn't committed

chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h"
 
 #include <string>
 #include <utility>
 
 #include "base/feature_list.h"
@@ skipping 67 matching lines @@
 }
 
 AdsPageLoadMetricsObserver::AdsPageLoadMetricsObserver() = default;
 AdsPageLoadMetricsObserver::~AdsPageLoadMetricsObserver() = default;
 
 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
 AdsPageLoadMetricsObserver::OnCommit(
     content::NavigationHandle* navigation_handle) {
   DCHECK(ad_frames_data_.empty());
 
+  committed_ = true;
+
   // The main frame is never considered an ad.
   ad_frames_data_[navigation_handle->GetFrameTreeNodeId()] = nullptr;
   ProcessOngoingNavigationResource(navigation_handle->GetFrameTreeNodeId());
   return CONTINUE_OBSERVING;
 }
 
 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
 AdsPageLoadMetricsObserver::OnDidFinishSubFrameNavigation(
     content::NavigationHandle* navigation_handle) {
   // Determine if the frame is part of an existing ad, the root of a new ad,
@@ skipping 101 matching lines @@
               extra_request_info.was_cached, extra_request_info.raw_body_bytes,
               extra_request_info.original_network_content_length, nullptr,
               extra_request_info.resource_type));
     } else {
       // This is unexpected, it could be:
       // 1. a resource from a previous navigation that started its resource
       //    load after this page started navigation.
       // 2. possibly a resource from a document.written frame whose frame
       //    failure message has yet to arrive. (uncertain of this)
     }
-    UMA_HISTOGRAM_ENUMERATION(
-        "PageLoad.Clients.Ads.Google.ResourceTypeWhenNoFrameFound",
-        extra_request_info.resource_type, content::RESOURCE_TYPE_LAST_TYPE);
+    if (committed_) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "PageLoad.Clients.Ads.Google.ResourceTypeWhenNoFrameFound",
+          extra_request_info.resource_type, content::RESOURCE_TYPE_LAST_TYPE);
+    }
 
     return;
   }
 
   page_bytes_ += extra_request_info.raw_body_bytes;
   if (!extra_request_info.was_cached)
     uncached_page_bytes_ += extra_request_info.raw_body_bytes;
 
   // Determine if the frame (or its ancestor) is an ad, if so attribute the
   // bytes to the highest ad ancestor.
@@ skipping 78 matching lines @@
 void AdsPageLoadMetricsObserver::ProcessOngoingNavigationResource(
     FrameTreeNodeId frame_tree_node_id) {
   const auto& frame_id_and_request =
       ongoing_navigation_resources_.find(frame_tree_node_id);
   if (frame_id_and_request == ongoing_navigation_resources_.end())
     return;
 
   ProcessLoadedResource(frame_id_and_request->second);
   ongoing_navigation_resources_.erase(frame_id_and_request);
 }