Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed (Closed)
Patch Set: Address comments from PS2 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
index 6312cdcf970edfe54a0066375c8d71cfd99d33bb..39962af7534a63b862acdf0c56ebdcc7cc3f436e 100644
--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
@@ -85,6 +85,8 @@ AdsPageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
DCHECK(ad_frames_data_.empty());
+ committed_ = true;
+
// The main frame is never considered an ad.
ad_frames_data_[navigation_handle->GetFrameTreeNodeId()] = nullptr;
ProcessOngoingNavigationResource(navigation_handle->GetFrameTreeNodeId());
@@ -206,9 +208,11 @@ void AdsPageLoadMetricsObserver::ProcessLoadedResource(
// 2. possibly a resource from a document.written frame whose frame
// failure message has yet to arrive. (uncertain of this)
}
- UMA_HISTOGRAM_ENUMERATION(
- "PageLoad.Clients.Ads.Google.ResourceTypeWhenNoFrameFound",
- extra_request_info.resource_type, content::RESOURCE_TYPE_LAST_TYPE);
+ if (committed_) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "PageLoad.Clients.Ads.Google.ResourceTypeWhenNoFrameFound",
+ extra_request_info.resource_type, content::RESOURCE_TYPE_LAST_TYPE);
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698