chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h - Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 2893633003: [PageLoadMetrics] Don't record an ads histogram if the page hasn't committed (Closed)

Patch Set: Address comments from PS2 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

index 90d7dd3176b16b732a745c9f814647310cf51be3..20ba9fbc545a9c046c45b6f0bf8b41e9872b9bb7 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

@@ -73,6 +73,8 @@ class PageLoadMetricsObserverTestHarness

const base::HistogramTester& histogram_tester() const;

+ MetricsWebContentsObserver* observer() const;

// Gets the PageLoadExtraInfo for the committed_load_ in observer_.

const PageLoadExtraInfo GetPageLoadExtraInfoForCommittedLoad();