Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)

Created:
3 years, 7 months ago by pdr.
Modified:
3 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor SetViewportLayerIds to use a struct instead of 6 values This patch refactors LayerTreeImpl::SetViewportLayerIds to use a ViewportLayerIds struct instead of 6 values. This is just a cleanup to make the code more readable. BUG=723263 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2889093003 Cr-Commit-Position: refs/heads/master@{#473030} Committed: https://chromium.googlesource.com/chromium/src/+/53abb45ba61e417487ad645357223efebd234b93

Patch Set 1 #

Patch Set 2 : Fix small mistake made in a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -171 lines) Patch
M cc/layers/layer_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 4 chunks +10 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 12 chunks +73 lines, -44 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +28 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 8 chunks +17 lines, -54 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 3 chunks +11 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
pdr.
3 years, 7 months ago (2017-05-18 19:07:24 UTC) #2
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-18 19:49:36 UTC) #5
wkorman
lgtm
3 years, 7 months ago (2017-05-18 20:19:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889093003/20001
3 years, 7 months ago (2017-05-18 20:29:22 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 02:00:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53abb45ba61e417487ad64535722...

Powered by Google App Engine
This is Rietveld 408576698