Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2888243002: Remove scroll_clip_layer dependency from LayerTreeImpl::ScrollableSize (Closed)

Created:
3 years, 7 months ago by pdr.
Modified:
3 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove scroll_clip_layer dependency from LayerTreeImpl::ScrollableSize This patch prepares for removing scroll_clip_layer by removing uses of scroll_clip_layer from LayerTreeImpl::ScrollableSize. BUG=723263 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2888243002 Cr-Commit-Position: refs/heads/master@{#472888} Committed: https://chromium.googlesource.com/chromium/src/+/78cd664ac3acc2860377064d0541b015486749d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -50 lines) Patch
M cc/trees/layer_tree_host_impl_unittest.cc View 14 chunks +68 lines, -42 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +12 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
pdr.
3 years, 7 months ago (2017-05-17 23:24:15 UTC) #2
wkorman
lgtm
3 years, 7 months ago (2017-05-17 23:30:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888243002/1
3 years, 7 months ago (2017-05-18 03:35:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/440702)
3 years, 7 months ago (2017-05-18 03:50:57 UTC) #7
pdr.
Oops, need OWNERS from chrishtr or enne
3 years, 7 months ago (2017-05-18 03:51:40 UTC) #8
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-18 04:35:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888243002/1
3 years, 7 months ago (2017-05-18 04:37:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448293)
3 years, 7 months ago (2017-05-18 08:09:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888243002/1
3 years, 7 months ago (2017-05-18 17:28:36 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:51:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78cd664ac3acc2860377064d0541...

Powered by Google App Engine
This is Rietveld 408576698