Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3147)

Unified Diff: cc/trees/layer_tree_impl.h

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)
Patch Set: Fix small mistake made in a test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.h
diff --git a/cc/trees/layer_tree_impl.h b/cc/trees/layer_tree_impl.h
index 1d574938134bfda1011247e34ff89a55ea90ef01..46f57fda5b625c775e9c8d0bb1647948137ce6c7 100644
--- a/cc/trees/layer_tree_impl.h
+++ b/cc/trees/layer_tree_impl.h
@@ -202,31 +202,44 @@ class CC_EXPORT LayerTreeImpl {
hud_layer_ = layer_impl;
}
- LayerImpl* InnerViewportScrollLayer() const;
- // This function may return NULL, it is the caller's responsibility to check.
- LayerImpl* OuterViewportScrollLayer() const;
gfx::ScrollOffset TotalScrollOffset() const;
gfx::ScrollOffset TotalMaxScrollOffset() const;
- LayerImpl* InnerViewportContainerLayer() const;
- LayerImpl* OuterViewportContainerLayer() const;
ScrollNode* CurrentlyScrollingNode();
const ScrollNode* CurrentlyScrollingNode() const;
int LastScrolledScrollNodeIndex() const;
void SetCurrentlyScrollingNode(ScrollNode* node);
void ClearCurrentlyScrollingNode();
- void SetViewportLayersFromIds(int overscroll_elasticity_layer,
- int page_scale_layer_id,
- int inner_viewport_container_layer_id,
- int outer_viewport_container_layer_id,
- int inner_viewport_scroll_layer_id,
- int outer_viewport_scroll_layer_id);
+ struct ViewportLayerIds {
+ int overscroll_elasticity = Layer::INVALID_ID;
+ int page_scale = Layer::INVALID_ID;
+ int inner_viewport_container = Layer::INVALID_ID;
+ int outer_viewport_container = Layer::INVALID_ID;
+ int inner_viewport_scroll = Layer::INVALID_ID;
+ int outer_viewport_scroll = Layer::INVALID_ID;
+ };
+ void SetViewportLayersFromIds(const ViewportLayerIds& viewport_layer_ids);
void ClearViewportLayers();
- LayerImpl* OverscrollElasticityLayer() {
- return LayerById(overscroll_elasticity_layer_id_);
+ LayerImpl* OverscrollElasticityLayer() const {
+ return LayerById(viewport_layer_ids_.overscroll_elasticity);
+ }
+ LayerImpl* PageScaleLayer() const {
+ return LayerById(viewport_layer_ids_.page_scale);
+ }
+ LayerImpl* InnerViewportContainerLayer() const {
+ return LayerById(viewport_layer_ids_.inner_viewport_container);
+ }
+ LayerImpl* OuterViewportContainerLayer() const {
+ return LayerById(viewport_layer_ids_.outer_viewport_container);
}
- LayerImpl* PageScaleLayer() { return LayerById(page_scale_layer_id_); }
+ LayerImpl* InnerViewportScrollLayer() const {
+ return LayerById(viewport_layer_ids_.inner_viewport_scroll);
+ }
+ LayerImpl* OuterViewportScrollLayer() const {
+ return LayerById(viewport_layer_ids_.outer_viewport_scroll);
+ }
+
void ApplySentScrollAndScaleDeltasFromAbortedCommit();
SkColor background_color() const { return background_color_; }
@@ -527,14 +540,8 @@ class CC_EXPORT LayerTreeImpl {
bool has_transparent_background_;
int last_scrolled_scroll_node_index_;
- int overscroll_elasticity_layer_id_;
- int page_scale_layer_id_;
-
- int inner_viewport_container_layer_id_;
- int outer_viewport_container_layer_id_;
- int inner_viewport_scroll_layer_id_;
- int outer_viewport_scroll_layer_id_;
+ ViewportLayerIds viewport_layer_ids_;
LayerSelection selection_;
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698