Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: cc/trees/layer_tree_host.cc

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)
Patch Set: Fix small mistake made in a test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/test/test_layer_tree_host_base.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host.h" 5 #include "cc/trees/layer_tree_host.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 28 matching lines...) Expand all
39 #include "cc/layers/heads_up_display_layer_impl.h" 39 #include "cc/layers/heads_up_display_layer_impl.h"
40 #include "cc/layers/layer.h" 40 #include "cc/layers/layer.h"
41 #include "cc/layers/painted_scrollbar_layer.h" 41 #include "cc/layers/painted_scrollbar_layer.h"
42 #include "cc/resources/ui_resource_manager.h" 42 #include "cc/resources/ui_resource_manager.h"
43 #include "cc/tiles/frame_viewer_instrumentation.h" 43 #include "cc/tiles/frame_viewer_instrumentation.h"
44 #include "cc/trees/draw_property_utils.h" 44 #include "cc/trees/draw_property_utils.h"
45 #include "cc/trees/effect_node.h" 45 #include "cc/trees/effect_node.h"
46 #include "cc/trees/layer_tree_host_client.h" 46 #include "cc/trees/layer_tree_host_client.h"
47 #include "cc/trees/layer_tree_host_common.h" 47 #include "cc/trees/layer_tree_host_common.h"
48 #include "cc/trees/layer_tree_host_impl.h" 48 #include "cc/trees/layer_tree_host_impl.h"
49 #include "cc/trees/layer_tree_impl.h"
50 #include "cc/trees/mutator_host.h" 49 #include "cc/trees/mutator_host.h"
51 #include "cc/trees/property_tree_builder.h" 50 #include "cc/trees/property_tree_builder.h"
52 #include "cc/trees/proxy_main.h" 51 #include "cc/trees/proxy_main.h"
53 #include "cc/trees/single_thread_proxy.h" 52 #include "cc/trees/single_thread_proxy.h"
54 #include "cc/trees/swap_promise_manager.h" 53 #include "cc/trees/swap_promise_manager.h"
55 #include "cc/trees/transform_node.h" 54 #include "cc/trees/transform_node.h"
56 #include "cc/trees/tree_synchronizer.h" 55 #include "cc/trees/tree_synchronizer.h"
57 #include "ui/gfx/geometry/size_conversions.h" 56 #include "ui/gfx/geometry/size_conversions.h"
58 #include "ui/gfx/geometry/vector2d_conversions.h" 57 #include "ui/gfx/geometry/vector2d_conversions.h"
59 58
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 EventListenerClass::kTouchStartOrMove, 1166 EventListenerClass::kTouchStartOrMove,
1168 event_listener_properties(EventListenerClass::kTouchStartOrMove)); 1167 event_listener_properties(EventListenerClass::kTouchStartOrMove));
1169 tree_impl->set_event_listener_properties( 1168 tree_impl->set_event_listener_properties(
1170 EventListenerClass::kMouseWheel, 1169 EventListenerClass::kMouseWheel,
1171 event_listener_properties(EventListenerClass::kMouseWheel)); 1170 event_listener_properties(EventListenerClass::kMouseWheel));
1172 tree_impl->set_event_listener_properties( 1171 tree_impl->set_event_listener_properties(
1173 EventListenerClass::kTouchEndOrCancel, 1172 EventListenerClass::kTouchEndOrCancel,
1174 event_listener_properties(EventListenerClass::kTouchEndOrCancel)); 1173 event_listener_properties(EventListenerClass::kTouchEndOrCancel));
1175 1174
1176 if (page_scale_layer_ && inner_viewport_scroll_layer_) { 1175 if (page_scale_layer_ && inner_viewport_scroll_layer_) {
1177 tree_impl->SetViewportLayersFromIds( 1176 LayerTreeImpl::ViewportLayerIds ids;
1178 overscroll_elasticity_layer_ ? overscroll_elasticity_layer_->id() 1177 if (overscroll_elasticity_layer_)
1179 : Layer::INVALID_ID, 1178 ids.overscroll_elasticity = overscroll_elasticity_layer_->id();
1180 page_scale_layer_->id(), 1179 ids.page_scale = page_scale_layer_->id();
1181 inner_viewport_container_layer_ ? inner_viewport_container_layer_->id() 1180 if (inner_viewport_container_layer_)
1182 : Layer::INVALID_ID, 1181 ids.inner_viewport_container = inner_viewport_container_layer_->id();
1183 outer_viewport_container_layer_ ? outer_viewport_container_layer_->id() 1182 if (outer_viewport_container_layer_)
1184 : Layer::INVALID_ID, 1183 ids.outer_viewport_container = outer_viewport_container_layer_->id();
1185 inner_viewport_scroll_layer_->id(), 1184 ids.inner_viewport_scroll = inner_viewport_scroll_layer_->id();
1186 outer_viewport_scroll_layer_ ? outer_viewport_scroll_layer_->id() 1185 if (outer_viewport_scroll_layer_)
1187 : Layer::INVALID_ID); 1186 ids.outer_viewport_scroll = outer_viewport_scroll_layer_->id();
1187 tree_impl->SetViewportLayersFromIds(ids);
1188 DCHECK(inner_viewport_scroll_layer_->IsContainerForFixedPositionLayers()); 1188 DCHECK(inner_viewport_scroll_layer_->IsContainerForFixedPositionLayers());
1189 } else { 1189 } else {
1190 tree_impl->ClearViewportLayers(); 1190 tree_impl->ClearViewportLayers();
1191 } 1191 }
1192 1192
1193 tree_impl->RegisterSelection(selection_); 1193 tree_impl->RegisterSelection(selection_);
1194 1194
1195 tree_impl->PushPageScaleFromMainThread( 1195 tree_impl->PushPageScaleFromMainThread(
1196 page_scale_factor_, min_page_scale_factor_, max_page_scale_factor_); 1196 page_scale_factor_, min_page_scale_factor_, max_page_scale_factor_);
1197 1197
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1484 void LayerTreeHost::SetNeedsDisplayOnAllLayers() { 1484 void LayerTreeHost::SetNeedsDisplayOnAllLayers() {
1485 for (auto* layer : *this) 1485 for (auto* layer : *this)
1486 layer->SetNeedsDisplay(); 1486 layer->SetNeedsDisplay();
1487 } 1487 }
1488 1488
1489 void LayerTreeHost::SetHasCopyRequest(bool has_copy_request) { 1489 void LayerTreeHost::SetHasCopyRequest(bool has_copy_request) {
1490 has_copy_request_ = has_copy_request; 1490 has_copy_request_ = has_copy_request;
1491 } 1491 }
1492 1492
1493 } // namespace cc 1493 } // namespace cc
OLDNEW
« no previous file with comments | « cc/test/test_layer_tree_host_base.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698