Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: cc/trees/layer_tree_impl.h

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)
Patch Set: Fix small mistake made in a test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_LAYER_TREE_IMPL_H_ 5 #ifndef CC_TREES_LAYER_TREE_IMPL_H_
6 #define CC_TREES_LAYER_TREE_IMPL_H_ 6 #define CC_TREES_LAYER_TREE_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 void set_is_first_frame_after_commit(bool is_first_frame_after_commit) { 195 void set_is_first_frame_after_commit(bool is_first_frame_after_commit) {
196 is_first_frame_after_commit_tracker_ = 196 is_first_frame_after_commit_tracker_ =
197 is_first_frame_after_commit ? -1 : source_frame_number_; 197 is_first_frame_after_commit ? -1 : source_frame_number_;
198 } 198 }
199 199
200 HeadsUpDisplayLayerImpl* hud_layer() { return hud_layer_; } 200 HeadsUpDisplayLayerImpl* hud_layer() { return hud_layer_; }
201 void set_hud_layer(HeadsUpDisplayLayerImpl* layer_impl) { 201 void set_hud_layer(HeadsUpDisplayLayerImpl* layer_impl) {
202 hud_layer_ = layer_impl; 202 hud_layer_ = layer_impl;
203 } 203 }
204 204
205 LayerImpl* InnerViewportScrollLayer() const;
206 // This function may return NULL, it is the caller's responsibility to check.
207 LayerImpl* OuterViewportScrollLayer() const;
208 gfx::ScrollOffset TotalScrollOffset() const; 205 gfx::ScrollOffset TotalScrollOffset() const;
209 gfx::ScrollOffset TotalMaxScrollOffset() const; 206 gfx::ScrollOffset TotalMaxScrollOffset() const;
210 207
211 LayerImpl* InnerViewportContainerLayer() const;
212 LayerImpl* OuterViewportContainerLayer() const;
213 ScrollNode* CurrentlyScrollingNode(); 208 ScrollNode* CurrentlyScrollingNode();
214 const ScrollNode* CurrentlyScrollingNode() const; 209 const ScrollNode* CurrentlyScrollingNode() const;
215 int LastScrolledScrollNodeIndex() const; 210 int LastScrolledScrollNodeIndex() const;
216 void SetCurrentlyScrollingNode(ScrollNode* node); 211 void SetCurrentlyScrollingNode(ScrollNode* node);
217 void ClearCurrentlyScrollingNode(); 212 void ClearCurrentlyScrollingNode();
218 213
219 void SetViewportLayersFromIds(int overscroll_elasticity_layer, 214 struct ViewportLayerIds {
220 int page_scale_layer_id, 215 int overscroll_elasticity = Layer::INVALID_ID;
221 int inner_viewport_container_layer_id, 216 int page_scale = Layer::INVALID_ID;
222 int outer_viewport_container_layer_id, 217 int inner_viewport_container = Layer::INVALID_ID;
223 int inner_viewport_scroll_layer_id, 218 int outer_viewport_container = Layer::INVALID_ID;
224 int outer_viewport_scroll_layer_id); 219 int inner_viewport_scroll = Layer::INVALID_ID;
220 int outer_viewport_scroll = Layer::INVALID_ID;
221 };
222 void SetViewportLayersFromIds(const ViewportLayerIds& viewport_layer_ids);
225 void ClearViewportLayers(); 223 void ClearViewportLayers();
226 LayerImpl* OverscrollElasticityLayer() { 224 LayerImpl* OverscrollElasticityLayer() const {
227 return LayerById(overscroll_elasticity_layer_id_); 225 return LayerById(viewport_layer_ids_.overscroll_elasticity);
228 } 226 }
229 LayerImpl* PageScaleLayer() { return LayerById(page_scale_layer_id_); } 227 LayerImpl* PageScaleLayer() const {
228 return LayerById(viewport_layer_ids_.page_scale);
229 }
230 LayerImpl* InnerViewportContainerLayer() const {
231 return LayerById(viewport_layer_ids_.inner_viewport_container);
232 }
233 LayerImpl* OuterViewportContainerLayer() const {
234 return LayerById(viewport_layer_ids_.outer_viewport_container);
235 }
236 LayerImpl* InnerViewportScrollLayer() const {
237 return LayerById(viewport_layer_ids_.inner_viewport_scroll);
238 }
239 LayerImpl* OuterViewportScrollLayer() const {
240 return LayerById(viewport_layer_ids_.outer_viewport_scroll);
241 }
242
230 void ApplySentScrollAndScaleDeltasFromAbortedCommit(); 243 void ApplySentScrollAndScaleDeltasFromAbortedCommit();
231 244
232 SkColor background_color() const { return background_color_; } 245 SkColor background_color() const { return background_color_; }
233 void set_background_color(SkColor color) { background_color_ = color; } 246 void set_background_color(SkColor color) { background_color_ = color; }
234 247
235 bool has_transparent_background() const { 248 bool has_transparent_background() const {
236 return has_transparent_background_; 249 return has_transparent_background_;
237 } 250 }
238 void set_has_transparent_background(bool transparent) { 251 void set_has_transparent_background(bool transparent) {
239 has_transparent_background_ = transparent; 252 has_transparent_background_ = transparent;
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 LayerTreeHostImpl* layer_tree_host_impl_; 533 LayerTreeHostImpl* layer_tree_host_impl_;
521 int source_frame_number_; 534 int source_frame_number_;
522 int is_first_frame_after_commit_tracker_; 535 int is_first_frame_after_commit_tracker_;
523 LayerImpl* root_layer_for_testing_; 536 LayerImpl* root_layer_for_testing_;
524 HeadsUpDisplayLayerImpl* hud_layer_; 537 HeadsUpDisplayLayerImpl* hud_layer_;
525 PropertyTrees property_trees_; 538 PropertyTrees property_trees_;
526 SkColor background_color_; 539 SkColor background_color_;
527 bool has_transparent_background_; 540 bool has_transparent_background_;
528 541
529 int last_scrolled_scroll_node_index_; 542 int last_scrolled_scroll_node_index_;
530 int overscroll_elasticity_layer_id_;
531 int page_scale_layer_id_;
532 543
533 int inner_viewport_container_layer_id_; 544 ViewportLayerIds viewport_layer_ids_;
534 int outer_viewport_container_layer_id_;
535
536 int inner_viewport_scroll_layer_id_;
537 int outer_viewport_scroll_layer_id_;
538 545
539 LayerSelection selection_; 546 LayerSelection selection_;
540 547
541 scoped_refptr<SyncedProperty<ScaleGroup>> page_scale_factor_; 548 scoped_refptr<SyncedProperty<ScaleGroup>> page_scale_factor_;
542 float min_page_scale_factor_; 549 float min_page_scale_factor_;
543 float max_page_scale_factor_; 550 float max_page_scale_factor_;
544 551
545 float device_scale_factor_; 552 float device_scale_factor_;
546 float painted_device_scale_factor_; 553 float painted_device_scale_factor_;
547 gfx::ColorSpace raster_color_space_; 554 gfx::ColorSpace raster_color_space_;
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 // lifecycle states. See: |LayerTreeLifecycle|. 633 // lifecycle states. See: |LayerTreeLifecycle|.
627 LayerTreeLifecycle lifecycle_; 634 LayerTreeLifecycle lifecycle_;
628 635
629 private: 636 private:
630 DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl); 637 DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl);
631 }; 638 };
632 639
633 } // namespace cc 640 } // namespace cc
634 641
635 #endif // CC_TREES_LAYER_TREE_IMPL_H_ 642 #endif // CC_TREES_LAYER_TREE_IMPL_H_
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698