Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: cc/trees/layer_tree_host.cc

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)
Patch Set: Fix small mistake made in a test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/test_layer_tree_host_base.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host.cc
diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc
index 89afd2742940c30b93a210e4aa830d9fe7b5d5dc..e826e2d93900d0e34f10261a4e00b6ac885ad6fc 100644
--- a/cc/trees/layer_tree_host.cc
+++ b/cc/trees/layer_tree_host.cc
@@ -46,7 +46,6 @@
#include "cc/trees/layer_tree_host_client.h"
#include "cc/trees/layer_tree_host_common.h"
#include "cc/trees/layer_tree_host_impl.h"
-#include "cc/trees/layer_tree_impl.h"
#include "cc/trees/mutator_host.h"
#include "cc/trees/property_tree_builder.h"
#include "cc/trees/proxy_main.h"
@@ -1174,17 +1173,18 @@ void LayerTreeHost::PushLayerTreePropertiesTo(LayerTreeImpl* tree_impl) {
event_listener_properties(EventListenerClass::kTouchEndOrCancel));
if (page_scale_layer_ && inner_viewport_scroll_layer_) {
- tree_impl->SetViewportLayersFromIds(
- overscroll_elasticity_layer_ ? overscroll_elasticity_layer_->id()
- : Layer::INVALID_ID,
- page_scale_layer_->id(),
- inner_viewport_container_layer_ ? inner_viewport_container_layer_->id()
- : Layer::INVALID_ID,
- outer_viewport_container_layer_ ? outer_viewport_container_layer_->id()
- : Layer::INVALID_ID,
- inner_viewport_scroll_layer_->id(),
- outer_viewport_scroll_layer_ ? outer_viewport_scroll_layer_->id()
- : Layer::INVALID_ID);
+ LayerTreeImpl::ViewportLayerIds ids;
+ if (overscroll_elasticity_layer_)
+ ids.overscroll_elasticity = overscroll_elasticity_layer_->id();
+ ids.page_scale = page_scale_layer_->id();
+ if (inner_viewport_container_layer_)
+ ids.inner_viewport_container = inner_viewport_container_layer_->id();
+ if (outer_viewport_container_layer_)
+ ids.outer_viewport_container = outer_viewport_container_layer_->id();
+ ids.inner_viewport_scroll = inner_viewport_scroll_layer_->id();
+ if (outer_viewport_scroll_layer_)
+ ids.outer_viewport_scroll = outer_viewport_scroll_layer_->id();
+ tree_impl->SetViewportLayersFromIds(ids);
DCHECK(inner_viewport_scroll_layer_->IsContainerForFixedPositionLayers());
} else {
tree_impl->ClearViewportLayers();
« no previous file with comments | « cc/test/test_layer_tree_host_base.cc ('k') | cc/trees/layer_tree_host_common_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698