Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: cc/test/fake_layer_tree_host.cc

Issue 2889093003: Refactor SetViewportLayerIds to use a struct instead of 6 values (Closed)
Patch Set: Fix small mistake made in a test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl_unittest.cc ('k') | cc/test/test_layer_tree_host_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/fake_layer_tree_host.cc
diff --git a/cc/test/fake_layer_tree_host.cc b/cc/test/fake_layer_tree_host.cc
index 46fa9319350ae40612abf8a2fb735de182df1b7f..96ce65688bb2ac6d118a05022fb942c5d8f6f5cc 100644
--- a/cc/test/fake_layer_tree_host.cc
+++ b/cc/test/fake_layer_tree_host.cc
@@ -79,19 +79,18 @@ LayerImpl* FakeLayerTreeHost::CommitAndCreateLayerImplTree() {
property_trees(), active_tree());
if (page_scale_layer() && inner_viewport_scroll_layer()) {
- active_tree()->SetViewportLayersFromIds(
- overscroll_elasticity_layer() ? overscroll_elasticity_layer()->id()
- : Layer::INVALID_ID,
- page_scale_layer()->id(),
- inner_viewport_container_layer()
- ? inner_viewport_container_layer()->id()
- : Layer::INVALID_ID,
- outer_viewport_container_layer()
- ? outer_viewport_container_layer()->id()
- : Layer::INVALID_ID,
- inner_viewport_scroll_layer()->id(),
- outer_viewport_scroll_layer() ? outer_viewport_scroll_layer()->id()
- : Layer::INVALID_ID);
+ LayerTreeImpl::ViewportLayerIds ids;
+ if (overscroll_elasticity_layer())
+ ids.overscroll_elasticity = overscroll_elasticity_layer()->id();
+ ids.page_scale = page_scale_layer()->id();
+ if (inner_viewport_container_layer())
+ ids.inner_viewport_container = inner_viewport_container_layer()->id();
+ if (outer_viewport_container_layer())
+ ids.outer_viewport_container = outer_viewport_container_layer()->id();
+ ids.inner_viewport_scroll = inner_viewport_scroll_layer()->id();
+ if (outer_viewport_scroll_layer())
+ ids.outer_viewport_scroll = outer_viewport_scroll_layer()->id();
+ active_tree()->SetViewportLayersFromIds(ids);
}
return active_tree()->root_layer_for_testing();
« no previous file with comments | « cc/layers/layer_impl_unittest.cc ('k') | cc/test/test_layer_tree_host_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698