Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)

Created:
3 years, 7 months ago by pdr.
Modified:
3 years, 7 months ago
Reviewers:
wkorman, enne (OOO)
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor RegisterViewportLayers to use a struct instead of 6 values This patch refactors LayerTreeHost::RegisterViewportLayers to use a ViewportLayers struct instead of 6 values. This is just a cleanup to make the code more readable. BUG=723263 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2886243004 Cr-Commit-Position: refs/heads/master@{#473485} Committed: https://chromium.googlesource.com/chromium/src/+/5200a050cd3a47af602de882ad2927b6af05c310

Patch Set 1 #

Patch Set 2 : Add ViewportLayers ctor and dtor #

Patch Set 3 : CC_EXPORT ViewportLayers to make the Windows compile+link happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -151 lines) Patch
M cc/layers/layer_position_constraint_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 2 chunks +18 lines, -20 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 5 chunks +33 lines, -32 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 4 chunks +24 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +19 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +42 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 chunk +29 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
pdr.
3 years, 7 months ago (2017-05-18 23:59:44 UTC) #2
wkorman
lgtm
3 years, 7 months ago (2017-05-19 00:09:48 UTC) #3
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-19 00:46:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886243004/1
3 years, 7 months ago (2017-05-19 02:07:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/271602) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-19 02:34:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886243004/20001
3 years, 7 months ago (2017-05-19 16:55:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886243004/40001
3 years, 7 months ago (2017-05-21 20:11:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/389559)
3 years, 7 months ago (2017-05-21 21:05:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886243004/40001
3 years, 7 months ago (2017-05-21 22:27:07 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 22:51:15 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5200a050cd3a47af602de882ad29...

Powered by Google App Engine
This is Rietveld 408576698