Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: cc/test/layer_tree_test.cc

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/layer_position_constraint_unittest.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/test/layer_tree_test.h" 5 #include "cc/test/layer_tree_test.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 inner_viewport_container_layer->id()); 61 inner_viewport_container_layer->id());
62 outer_scroll_layer->SetScrollClipLayerId( 62 outer_scroll_layer->SetScrollClipLayerId(
63 outer_viewport_container_layer->id()); 63 outer_viewport_container_layer->id());
64 64
65 inner_viewport_container_layer->SetBounds(inner_bounds); 65 inner_viewport_container_layer->SetBounds(inner_bounds);
66 inner_viewport_scroll_layer->SetBounds(outer_bounds); 66 inner_viewport_scroll_layer->SetBounds(outer_bounds);
67 outer_viewport_container_layer->SetBounds(outer_bounds); 67 outer_viewport_container_layer->SetBounds(outer_bounds);
68 68
69 inner_viewport_scroll_layer->SetIsContainerForFixedPositionLayers(true); 69 inner_viewport_scroll_layer->SetIsContainerForFixedPositionLayers(true);
70 outer_scroll_layer->SetIsContainerForFixedPositionLayers(true); 70 outer_scroll_layer->SetIsContainerForFixedPositionLayers(true);
71 host->RegisterViewportLayers(overscroll_elasticity_layer, page_scale_layer, 71 LayerTreeHost::ViewportLayers viewport_layers;
72 inner_viewport_container_layer, 72 viewport_layers.overscroll_elasticity = overscroll_elasticity_layer;
73 outer_viewport_container_layer, 73 viewport_layers.page_scale = page_scale_layer;
74 inner_viewport_scroll_layer, outer_scroll_layer); 74 viewport_layers.inner_viewport_container = inner_viewport_container_layer;
75 viewport_layers.outer_viewport_container = outer_viewport_container_layer;
76 viewport_layers.inner_viewport_scroll = inner_viewport_scroll_layer;
77 viewport_layers.outer_viewport_scroll = outer_scroll_layer;
78 host->RegisterViewportLayers(viewport_layers);
75 } 79 }
76 80
77 void CreateVirtualViewportLayers(Layer* root_layer, 81 void CreateVirtualViewportLayers(Layer* root_layer,
78 const gfx::Size& inner_bounds, 82 const gfx::Size& inner_bounds,
79 const gfx::Size& outer_bounds, 83 const gfx::Size& outer_bounds,
80 const gfx::Size& scroll_bounds, 84 const gfx::Size& scroll_bounds,
81 LayerTreeHost* host) { 85 LayerTreeHost* host) {
82 scoped_refptr<Layer> outer_viewport_scroll_layer = Layer::Create(); 86 scoped_refptr<Layer> outer_viewport_scroll_layer = Layer::Create();
83 87
84 outer_viewport_scroll_layer->SetBounds(scroll_bounds); 88 outer_viewport_scroll_layer->SetBounds(scroll_bounds);
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 DCHECK(task_runner_provider()->IsMainThread() || 906 DCHECK(task_runner_provider()->IsMainThread() ||
903 task_runner_provider()->IsMainThreadBlocked()); 907 task_runner_provider()->IsMainThreadBlocked());
904 return layer_tree_host_.get(); 908 return layer_tree_host_.get();
905 } 909 }
906 910
907 Proxy* LayerTreeTest::proxy() { 911 Proxy* LayerTreeTest::proxy() {
908 return layer_tree_host() ? layer_tree_host()->proxy() : NULL; 912 return layer_tree_host() ? layer_tree_host()->proxy() : NULL;
909 } 913 }
910 914
911 } // namespace cc 915 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/layer_position_constraint_unittest.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698