Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: cc/trees/layer_tree_host.h

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_LAYER_TREE_HOST_H_ 5 #ifndef CC_TREES_LAYER_TREE_HOST_H_
6 #define CC_TREES_LAYER_TREE_HOST_H_ 6 #define CC_TREES_LAYER_TREE_HOST_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 void SetNextCommitWaitsForActivation(); 234 void SetNextCommitWaitsForActivation();
235 235
236 // The LayerTreeHost tracks whether the content is suitable for Gpu raster. 236 // The LayerTreeHost tracks whether the content is suitable for Gpu raster.
237 // Calling this will reset it back to not suitable state. 237 // Calling this will reset it back to not suitable state.
238 void ResetGpuRasterizationTracking(); 238 void ResetGpuRasterizationTracking();
239 239
240 void SetRootLayer(scoped_refptr<Layer> root_layer); 240 void SetRootLayer(scoped_refptr<Layer> root_layer);
241 Layer* root_layer() { return root_layer_.get(); } 241 Layer* root_layer() { return root_layer_.get(); }
242 const Layer* root_layer() const { return root_layer_.get(); } 242 const Layer* root_layer() const { return root_layer_.get(); }
243 243
244 void RegisterViewportLayers( 244 struct CC_EXPORT ViewportLayers {
245 scoped_refptr<Layer> overscroll_elasticity_layer, 245 ViewportLayers();
246 scoped_refptr<Layer> page_scale_layer, 246 ~ViewportLayers();
247 scoped_refptr<Layer> inner_viewport_container_layer, 247 scoped_refptr<Layer> overscroll_elasticity;
248 scoped_refptr<Layer> outer_viewport_container_layer, 248 scoped_refptr<Layer> page_scale;
249 scoped_refptr<Layer> inner_viewport_scroll_layer, 249 scoped_refptr<Layer> inner_viewport_container;
250 scoped_refptr<Layer> outer_viewport_scroll_layer); 250 scoped_refptr<Layer> outer_viewport_container;
251 251 scoped_refptr<Layer> inner_viewport_scroll;
252 scoped_refptr<Layer> outer_viewport_scroll;
253 };
254 void RegisterViewportLayers(const ViewportLayers& viewport_layers);
252 Layer* overscroll_elasticity_layer() const { 255 Layer* overscroll_elasticity_layer() const {
253 return overscroll_elasticity_layer_.get(); 256 return viewport_layers_.overscroll_elasticity.get();
254 } 257 }
255 Layer* page_scale_layer() const { return page_scale_layer_.get(); } 258 Layer* page_scale_layer() const { return viewport_layers_.page_scale.get(); }
256 Layer* inner_viewport_container_layer() const { 259 Layer* inner_viewport_container_layer() const {
257 return inner_viewport_container_layer_.get(); 260 return viewport_layers_.inner_viewport_container.get();
258 } 261 }
259 Layer* outer_viewport_container_layer() const { 262 Layer* outer_viewport_container_layer() const {
260 return outer_viewport_container_layer_.get(); 263 return viewport_layers_.outer_viewport_container.get();
261 } 264 }
262 Layer* inner_viewport_scroll_layer() const { 265 Layer* inner_viewport_scroll_layer() const {
263 return inner_viewport_scroll_layer_.get(); 266 return viewport_layers_.inner_viewport_scroll.get();
264 } 267 }
265 Layer* outer_viewport_scroll_layer() const { 268 Layer* outer_viewport_scroll_layer() const {
266 return outer_viewport_scroll_layer_.get(); 269 return viewport_layers_.outer_viewport_scroll.get();
267 } 270 }
268 271
269 void RegisterSelection(const LayerSelection& selection); 272 void RegisterSelection(const LayerSelection& selection);
270 const LayerSelection& selection() const { return selection_; } 273 const LayerSelection& selection() const { return selection_; }
271 274
272 void SetHaveScrollEventHandlers(bool have_event_handlers); 275 void SetHaveScrollEventHandlers(bool have_event_handlers);
273 bool have_scroll_event_handlers() const { 276 bool have_scroll_event_handlers() const {
274 return have_scroll_event_handlers_; 277 return have_scroll_event_handlers_;
275 } 278 }
276 279
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 // destroyed midway which causes a crash. crbug.com/654672 567 // destroyed midway which causes a crash. crbug.com/654672
565 bool inside_main_frame_ = false; 568 bool inside_main_frame_ = false;
566 569
567 TaskGraphRunner* task_graph_runner_; 570 TaskGraphRunner* task_graph_runner_;
568 571
569 SurfaceSequenceGenerator surface_sequence_generator_; 572 SurfaceSequenceGenerator surface_sequence_generator_;
570 uint32_t num_consecutive_frames_suitable_for_gpu_ = 0; 573 uint32_t num_consecutive_frames_suitable_for_gpu_ = 0;
571 574
572 scoped_refptr<Layer> root_layer_; 575 scoped_refptr<Layer> root_layer_;
573 576
574 scoped_refptr<Layer> overscroll_elasticity_layer_; 577 ViewportLayers viewport_layers_;
575 scoped_refptr<Layer> page_scale_layer_;
576 scoped_refptr<Layer> inner_viewport_container_layer_;
577 scoped_refptr<Layer> outer_viewport_container_layer_;
578 scoped_refptr<Layer> inner_viewport_scroll_layer_;
579 scoped_refptr<Layer> outer_viewport_scroll_layer_;
580 578
581 float top_controls_height_ = 0.f; 579 float top_controls_height_ = 0.f;
582 float top_controls_shown_ratio_ = 0.f; 580 float top_controls_shown_ratio_ = 0.f;
583 bool browser_controls_shrink_blink_size_ = false; 581 bool browser_controls_shrink_blink_size_ = false;
584 582
585 float bottom_controls_height_ = 0.f; 583 float bottom_controls_height_ = 0.f;
586 584
587 float device_scale_factor_ = 1.f; 585 float device_scale_factor_ = 1.f;
588 float painted_device_scale_factor_ = 1.f; 586 float painted_device_scale_factor_ = 1.f;
589 float page_scale_factor_ = 1.f; 587 float page_scale_factor_ = 1.f;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 634
637 std::vector<std::pair<sk_sp<const SkImage>, base::Callback<void(bool)>>> 635 std::vector<std::pair<sk_sp<const SkImage>, base::Callback<void(bool)>>>
638 queued_image_decodes_; 636 queued_image_decodes_;
639 637
640 DISALLOW_COPY_AND_ASSIGN(LayerTreeHost); 638 DISALLOW_COPY_AND_ASSIGN(LayerTreeHost);
641 }; 639 };
642 640
643 } // namespace cc 641 } // namespace cc
644 642
645 #endif // CC_TREES_LAYER_TREE_HOST_H_ 643 #endif // CC_TREES_LAYER_TREE_HOST_H_
OLDNEW
« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698