Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebLayerTreeViewImplForTesting_h 5 #ifndef WebLayerTreeViewImplForTesting_h
6 #define WebLayerTreeViewImplForTesting_h 6 #define WebLayerTreeViewImplForTesting_h
7 7
8 #include "cc/test/test_task_graph_runner.h" 8 #include "cc/test/test_task_graph_runner.h"
9 #include "cc/trees/layer_tree_host_client.h" 9 #include "cc/trees/layer_tree_host_client.h"
10 #include "cc/trees/layer_tree_host_single_thread_client.h" 10 #include "cc/trees/layer_tree_host_single_thread_client.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 void SetPageScaleFactorAndLimits(float page_scale_factor, 51 void SetPageScaleFactorAndLimits(float page_scale_factor,
52 float minimum, 52 float minimum,
53 float maximum) override; 53 float maximum) override;
54 void StartPageScaleAnimation(const blink::WebPoint& destination, 54 void StartPageScaleAnimation(const blink::WebPoint& destination,
55 bool use_anchor, 55 bool use_anchor,
56 float new_page_scale, 56 float new_page_scale,
57 double duration_sec) override; 57 double duration_sec) override;
58 void SetNeedsBeginFrame() override; 58 void SetNeedsBeginFrame() override;
59 void DidStopFlinging() override; 59 void DidStopFlinging() override;
60 void SetDeferCommits(bool) override; 60 void SetDeferCommits(bool) override;
61 // TODO(pdr): Refactor to use a struct like LayerTreeHost::ViewportLayers.
61 void RegisterViewportLayers( 62 void RegisterViewportLayers(
62 const blink::WebLayer* overscroll_elasticity_layer, 63 const blink::WebLayer* overscroll_elasticity_layer,
63 const blink::WebLayer* page_scale_layer_layer, 64 const blink::WebLayer* page_scale_layer_layer,
64 const blink::WebLayer* inner_viewport_container_layer, 65 const blink::WebLayer* inner_viewport_container_layer,
65 const blink::WebLayer* outer_viewport_container_layer, 66 const blink::WebLayer* outer_viewport_container_layer,
66 const blink::WebLayer* inner_viewport_scroll_layer, 67 const blink::WebLayer* inner_viewport_scroll_layer,
67 const blink::WebLayer* outer_viewport_scroll_layer) override; 68 const blink::WebLayer* outer_viewport_scroll_layer) override;
68 void ClearViewportLayers() override; 69 void ClearViewportLayers() override;
69 void RegisterSelection(const blink::WebSelection&) override; 70 void RegisterSelection(const blink::WebSelection&) override;
70 void ClearSelection() override; 71 void ClearSelection() override;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 107
107 private: 108 private:
108 cc::TestTaskGraphRunner task_graph_runner_; 109 cc::TestTaskGraphRunner task_graph_runner_;
109 std::unique_ptr<cc::AnimationHost> animation_host_; 110 std::unique_ptr<cc::AnimationHost> animation_host_;
110 std::unique_ptr<cc::LayerTreeHost> layer_tree_host_; 111 std::unique_ptr<cc::LayerTreeHost> layer_tree_host_;
111 }; 112 };
112 113
113 } // namespace blink 114 } // namespace blink
114 115
115 #endif // WebLayerTreeViewImplForTesting_h 116 #endif // WebLayerTreeViewImplForTesting_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698