Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: content/renderer/gpu/render_widget_compositor.h

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_ 5 #ifndef CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_
6 #define CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_ 6 #define CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 double duration_sec) override; 138 double duration_sec) override;
139 bool HasPendingPageScaleAnimation() const override; 139 bool HasPendingPageScaleAnimation() const override;
140 void HeuristicsForGpuRasterizationUpdated(bool matches_heuristics) override; 140 void HeuristicsForGpuRasterizationUpdated(bool matches_heuristics) override;
141 void SetNeedsBeginFrame() override; 141 void SetNeedsBeginFrame() override;
142 void DidStopFlinging() override; 142 void DidStopFlinging() override;
143 void LayoutAndPaintAsync( 143 void LayoutAndPaintAsync(
144 blink::WebLayoutAndPaintAsyncCallback* callback) override; 144 blink::WebLayoutAndPaintAsyncCallback* callback) override;
145 void CompositeAndReadbackAsync( 145 void CompositeAndReadbackAsync(
146 blink::WebCompositeAndReadbackAsyncCallback* callback) override; 146 blink::WebCompositeAndReadbackAsyncCallback* callback) override;
147 void SetDeferCommits(bool defer_commits) override; 147 void SetDeferCommits(bool defer_commits) override;
148 // TODO(pdr): Refactor to use a struct like LayerTreeHost::ViewportLayers.
148 void RegisterViewportLayers( 149 void RegisterViewportLayers(
149 const blink::WebLayer* overscrollElasticityLayer, 150 const blink::WebLayer* overscrollElasticityLayer,
150 const blink::WebLayer* pageScaleLayer, 151 const blink::WebLayer* pageScaleLayer,
151 const blink::WebLayer* innerViewportContainerLayer, 152 const blink::WebLayer* innerViewportContainerLayer,
152 const blink::WebLayer* outerViewportContainerLayer, 153 const blink::WebLayer* outerViewportContainerLayer,
153 const blink::WebLayer* innerViewportScrollLayer, 154 const blink::WebLayer* innerViewportScrollLayer,
154 const blink::WebLayer* outerViewportScrollLayer) override; 155 const blink::WebLayer* outerViewportScrollLayer) override;
155 void ClearViewportLayers() override; 156 void ClearViewportLayers() override;
156 void RegisterSelection(const blink::WebSelection& selection) override; 157 void RegisterSelection(const blink::WebSelection& selection) override;
157 void ClearSelection() override; 158 void ClearSelection() override;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 cc::FrameSinkId frame_sink_id_; 247 cc::FrameSinkId frame_sink_id_;
247 248
248 base::WeakPtrFactory<RenderWidgetCompositor> weak_factory_; 249 base::WeakPtrFactory<RenderWidgetCompositor> weak_factory_;
249 250
250 DISALLOW_COPY_AND_ASSIGN(RenderWidgetCompositor); 251 DISALLOW_COPY_AND_ASSIGN(RenderWidgetCompositor);
251 }; 252 };
252 253
253 } // namespace content 254 } // namespace content
254 255
255 #endif // CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_ 256 #endif // CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_unittest_scroll.cc ('k') | content/renderer/gpu/render_widget_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698