Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
diff --git a/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp b/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
index 19caa9eddcf3754fb5debf323eb66440eda02222..18b5bd1f4c32581935d45d6006c05fb4a4fec072 100644
--- a/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
+++ b/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp
@@ -153,35 +153,39 @@ void WebLayerTreeViewImplForTesting::RegisterViewportLayers(
const blink::WebLayer* outer_viewport_container_layer,
const blink::WebLayer* inner_viewport_scroll_layer,
const blink::WebLayer* outer_viewport_scroll_layer) {
- layer_tree_host_->RegisterViewportLayers(
- overscroll_elasticity_layer ? static_cast<const cc_blink::WebLayerImpl*>(
- overscroll_elasticity_layer)
- ->layer()
- : nullptr,
- static_cast<const cc_blink::WebLayerImpl*>(page_scale_layer)->layer(),
- inner_viewport_container_layer
- ? static_cast<const cc_blink::WebLayerImpl*>(
- inner_viewport_container_layer)
- ->layer()
- : nullptr,
- outer_viewport_container_layer
- ? static_cast<const cc_blink::WebLayerImpl*>(
- outer_viewport_container_layer)
- ->layer()
- : nullptr,
+ cc::LayerTreeHost::ViewportLayers viewport_layers;
+ if (overscroll_elasticity_layer) {
+ viewport_layers.overscroll_elasticity =
+ static_cast<const cc_blink::WebLayerImpl*>(overscroll_elasticity_layer)
+ ->layer();
+ }
+ viewport_layers.page_scale =
+ static_cast<const cc_blink::WebLayerImpl*>(page_scale_layer)->layer();
+ if (inner_viewport_container_layer) {
+ viewport_layers.inner_viewport_container =
+ static_cast<const cc_blink::WebLayerImpl*>(
+ inner_viewport_container_layer)
+ ->layer();
+ }
+ if (outer_viewport_container_layer) {
+ viewport_layers.outer_viewport_container =
+ static_cast<const cc_blink::WebLayerImpl*>(
+ outer_viewport_container_layer)
+ ->layer();
+ }
+ viewport_layers.inner_viewport_scroll =
static_cast<const cc_blink::WebLayerImpl*>(inner_viewport_scroll_layer)
- ->layer(),
- outer_viewport_scroll_layer ? static_cast<const cc_blink::WebLayerImpl*>(
- outer_viewport_scroll_layer)
- ->layer()
- : nullptr);
+ ->layer();
+ if (outer_viewport_scroll_layer) {
+ viewport_layers.outer_viewport_scroll =
+ static_cast<const cc_blink::WebLayerImpl*>(outer_viewport_scroll_layer)
+ ->layer();
+ }
+ layer_tree_host_->RegisterViewportLayers(viewport_layers);
}
void WebLayerTreeViewImplForTesting::ClearViewportLayers() {
- layer_tree_host_->RegisterViewportLayers(
- scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
- scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
- scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>());
+ layer_tree_host_->RegisterViewportLayers(cc::LayerTreeHost::ViewportLayers());
}
void WebLayerTreeViewImplForTesting::RegisterSelection(
« no previous file with comments | « third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698