Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp

Issue 2886243004: Refactor RegisterViewportLayers to use a struct instead of 6 values (Closed)
Patch Set: CC_EXPORT ViewportLayers to make the Windows compile+link happy. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/testing/WebLayerTreeViewImplForTesting.h" 5 #include "platform/testing/WebLayerTreeViewImplForTesting.h"
6 6
7 #include "base/threading/thread_task_runner_handle.h" 7 #include "base/threading/thread_task_runner_handle.h"
8 #include "cc/animation/animation_host.h" 8 #include "cc/animation/animation_host.h"
9 #include "cc/animation/animation_timeline.h" 9 #include "cc/animation/animation_timeline.h"
10 #include "cc/blink/web_layer_impl.h" 10 #include "cc/blink/web_layer_impl.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 NOTREACHED(); 146 NOTREACHED();
147 } 147 }
148 148
149 void WebLayerTreeViewImplForTesting::RegisterViewportLayers( 149 void WebLayerTreeViewImplForTesting::RegisterViewportLayers(
150 const blink::WebLayer* overscroll_elasticity_layer, 150 const blink::WebLayer* overscroll_elasticity_layer,
151 const blink::WebLayer* page_scale_layer, 151 const blink::WebLayer* page_scale_layer,
152 const blink::WebLayer* inner_viewport_container_layer, 152 const blink::WebLayer* inner_viewport_container_layer,
153 const blink::WebLayer* outer_viewport_container_layer, 153 const blink::WebLayer* outer_viewport_container_layer,
154 const blink::WebLayer* inner_viewport_scroll_layer, 154 const blink::WebLayer* inner_viewport_scroll_layer,
155 const blink::WebLayer* outer_viewport_scroll_layer) { 155 const blink::WebLayer* outer_viewport_scroll_layer) {
156 layer_tree_host_->RegisterViewportLayers( 156 cc::LayerTreeHost::ViewportLayers viewport_layers;
157 overscroll_elasticity_layer ? static_cast<const cc_blink::WebLayerImpl*>( 157 if (overscroll_elasticity_layer) {
158 overscroll_elasticity_layer) 158 viewport_layers.overscroll_elasticity =
159 ->layer() 159 static_cast<const cc_blink::WebLayerImpl*>(overscroll_elasticity_layer)
160 : nullptr, 160 ->layer();
161 static_cast<const cc_blink::WebLayerImpl*>(page_scale_layer)->layer(), 161 }
162 inner_viewport_container_layer 162 viewport_layers.page_scale =
163 ? static_cast<const cc_blink::WebLayerImpl*>( 163 static_cast<const cc_blink::WebLayerImpl*>(page_scale_layer)->layer();
164 inner_viewport_container_layer) 164 if (inner_viewport_container_layer) {
165 ->layer() 165 viewport_layers.inner_viewport_container =
166 : nullptr, 166 static_cast<const cc_blink::WebLayerImpl*>(
167 outer_viewport_container_layer 167 inner_viewport_container_layer)
168 ? static_cast<const cc_blink::WebLayerImpl*>( 168 ->layer();
169 outer_viewport_container_layer) 169 }
170 ->layer() 170 if (outer_viewport_container_layer) {
171 : nullptr, 171 viewport_layers.outer_viewport_container =
172 static_cast<const cc_blink::WebLayerImpl*>(
173 outer_viewport_container_layer)
174 ->layer();
175 }
176 viewport_layers.inner_viewport_scroll =
172 static_cast<const cc_blink::WebLayerImpl*>(inner_viewport_scroll_layer) 177 static_cast<const cc_blink::WebLayerImpl*>(inner_viewport_scroll_layer)
173 ->layer(), 178 ->layer();
174 outer_viewport_scroll_layer ? static_cast<const cc_blink::WebLayerImpl*>( 179 if (outer_viewport_scroll_layer) {
175 outer_viewport_scroll_layer) 180 viewport_layers.outer_viewport_scroll =
176 ->layer() 181 static_cast<const cc_blink::WebLayerImpl*>(outer_viewport_scroll_layer)
177 : nullptr); 182 ->layer();
183 }
184 layer_tree_host_->RegisterViewportLayers(viewport_layers);
178 } 185 }
179 186
180 void WebLayerTreeViewImplForTesting::ClearViewportLayers() { 187 void WebLayerTreeViewImplForTesting::ClearViewportLayers() {
181 layer_tree_host_->RegisterViewportLayers( 188 layer_tree_host_->RegisterViewportLayers(cc::LayerTreeHost::ViewportLayers());
182 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
183 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>(),
184 scoped_refptr<cc::Layer>(), scoped_refptr<cc::Layer>());
185 } 189 }
186 190
187 void WebLayerTreeViewImplForTesting::RegisterSelection( 191 void WebLayerTreeViewImplForTesting::RegisterSelection(
188 const blink::WebSelection& selection) {} 192 const blink::WebSelection& selection) {}
189 193
190 void WebLayerTreeViewImplForTesting::ClearSelection() {} 194 void WebLayerTreeViewImplForTesting::ClearSelection() {}
191 195
192 void WebLayerTreeViewImplForTesting::SetEventListenerProperties( 196 void WebLayerTreeViewImplForTesting::SetEventListenerProperties(
193 blink::WebEventListenerClass event_class, 197 blink::WebEventListenerClass event_class,
194 blink::WebEventListenerProperties properties) { 198 blink::WebEventListenerProperties properties) {
(...skipping 19 matching lines...) Expand all
214 218
215 bool WebLayerTreeViewImplForTesting::HaveScrollEventHandlers() const { 219 bool WebLayerTreeViewImplForTesting::HaveScrollEventHandlers() const {
216 return layer_tree_host_->have_scroll_event_handlers(); 220 return layer_tree_host_->have_scroll_event_handlers();
217 } 221 }
218 222
219 bool WebLayerTreeViewImplForTesting::IsForSubframe() { 223 bool WebLayerTreeViewImplForTesting::IsForSubframe() {
220 return false; 224 return false;
221 } 225 }
222 226
223 } // namespace blink 227 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698