supersize: Move [clone] from name -> flags & rewrite Cluster()

supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is now Clustered() by default.
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
Review-Url: https://codereview.chromium.org/2885073002
Cr-Commit-Position: refs/heads/master@{#472162}
Committed: https://chromium.googlesource.com/chromium/src/+/89689737e4beb0d37a4037215b3fd2b2bd32010d

[agrieve, 2017-05-16 15:43:19]

Description was changed from

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is not Clustered() by default, and
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
==========

to

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is not Clustered() by default, and
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
==========

[agrieve, 2017-05-16 15:43:20]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-05-16 15:43:29]

On 2017/05/16 15:43:20, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🎼

[estevenson, 2017-05-16 17:41:44]

lgtm, also s/not/now in commit message

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:600: if prev.__class__ == list:
Curious if there's a reason you used __class__ instead of isinstance()?

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:644: return '&' + hex(id(symbol))
nit: add a comment saying what this means?

[agrieve, 2017-05-16 17:43:18]

Description was changed from

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is not Clustered() by default, and
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
==========

to

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is now Clustered() by default.
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
==========

[agrieve, 2017-05-16 17:46:18]

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:600: if prev.__class__ == list:
On 2017/05/16 17:41:44, estevenson wrote:
> Curious if there's a reason you used __class__ instead of isinstance()?

Should be faster, because python doesn't need to walk the inheritance tree.

https://codereview.chromium.org/2885073002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:644: return '&' + hex(id(symbol))
On 2017/05/16 17:41:44, estevenson wrote:
> nit: add a comment saying what this means?

Done.

[agrieve, 2017-05-16 17:46:24]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-05-16 17:46:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2885073002/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2017-05-16 17:47:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494956784960170,
"parent_rev": "2ccf86ba657e1450597a26bb941bd332eff3ab8c", "commit_rev":
"89689737e4beb0d37a4037215b3fd2b2bd32010d"}

[commit-bot: I haz the power, 2017-05-16 18:11:33]

Description was changed from

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is now Clustered() by default.
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694
==========

to

==========
supersize: Move [clone] from name -> flags & rewrite Cluster()

SizeInfo.symbols is now Clustered() by default.
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694

Review-Url: https://codereview.chromium.org/2885073002
Cr-Commit-Position: refs/heads/master@{#472162}
Committed:
https://chromium.googlesource.com/chromium/src/+/89689737e4beb0d37a4037215b3f...
==========

[commit-bot: I haz the power, 2017-05-16 18:11:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89689737e4beb0d37a4037215b3f...