supersize: Move [clone] from name -> flags & rewrite Cluster()

tools/binary_size/libsupersize/archive.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Main Python API for analyzing binary size."""
 
 import argparse
 import calendar
 import collections
 import datetime
@@ skipping 74 matching lines @@
   """
   found_prefixes = set()
   for symbol in raw_symbols:
     if symbol.full_name.startswith('*'):
       # See comment in _CalculatePadding() about when this
       # can happen.
       symbol.template_name = symbol.full_name
       symbol.name = symbol.full_name
       continue
 
+    # Remove [clone] suffix, and set flag accordingly.
+    # Search from left-to-right, as multiple [clone]s can exist.
+    # Example name suffixes:
+    #     [clone .part.322]  # GCC
+    #     [clone .isra.322]  # GCC
+    #     [clone .constprop.1064]  # GCC
+    #     [clone .11064]  # clang
+    # http://unix.stackexchange.com/questions/223013/function-symbol-gets-part-suffix-after-compilation
+    idx = symbol.full_name.find(' [clone ')
+    if idx != -1:
+      symbol.full_name = symbol.full_name[:idx]
+      symbol.flags |= models.FLAG_CLONE
+
     # E.g.: vtable for FOO
     idx = symbol.full_name.find(' for ', 0, 30)
     if idx != -1:
       found_prefixes.add(symbol.full_name[:idx + 4])
       symbol.full_name = (
           symbol.full_name[idx + 5:] + ' [' + symbol.full_name[:idx] + ']')
 
     # E.g.: virtual thunk to FOO
     idx = symbol.full_name.find(' to ', 0, 30)
     if idx != -1:
@@ skipping 52 matching lines @@
   # We don't have source info for prebuilt .a files.
   if not os.path.isabs(object_path) and not object_path.startswith('..'):
     source_path = source_mapper.FindSourceForPath(object_path)
     if source_path:
       return _NormalizeSourcePath(source_path)
   return False, ''
 
 
 def _ExtractSourcePaths(raw_symbols, source_mapper):
   """Fills in the |source_path| attribute."""
-  logging.debug('Parsed %d .ninja files.', source_mapper.parsed_file_count)
   for symbol in raw_symbols:
     object_path = symbol.object_path
     if object_path and not symbol.source_path:
       symbol.generated_source, symbol.source_path = (
           _SourcePathForObjectPath(object_path, source_mapper))
 
 
 def _ComputeAnscestorPath(path_list):
   """Returns the common anscestor of the given paths."""
   # Ignore missing paths.
@@ skipping 240 matching lines @@
     output_directory: Build output directory. If None, source_paths and symbol
         alias information will not be recorded.
   """
   source_mapper = None
   if output_directory:
     # Start by finding the elf_object_paths, so that nm can run on them while
     # the linker .map is being parsed.
     logging.info('Parsing ninja files.')
     source_mapper, elf_object_paths = ninja_parser.Parse(
         output_directory, elf_path)
+    logging.debug('Parsed %d .ninja files.', source_mapper.parsed_file_count)
     assert not elf_path or elf_object_paths, (
         'Failed to find link command in ninja files for ' +
         os.path.relpath(elf_path, output_directory))
 
   if elf_path:
     # Run nm on the elf file to retrieve the list of symbol names per-address.
     # This list is required because the .map file contains only a single name
     # for each address, yet multiple symbols are often coalesced when they are
     # identical. This coalescing happens mainly for small symbols and for C++
     # templates. Such symbols make up ~500kb of libchrome.so on Android.
@@ skipping 250 matching lines @@
           logging.warning('Packed section not present: %s', packed_section_name)
         else:
           size_info.section_sizes['%s (unpacked)' % packed_section_name] = (
               unstripped_section_sizes.get(packed_section_name))
 
   logging.info('Recording metadata: \n  %s',
                '\n  '.join(describe.DescribeMetadata(size_info.metadata)))
   logging.info('Saving result to %s', args.size_file)
   file_format.SaveSizeInfo(size_info, args.size_file)
   logging.info('Done')