Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/binary_size/libsupersize/file_format.py

Issue 2885073002: supersize: Move [clone] from name -> flags & rewrite Cluster() (Closed)
Patch Set: review comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/diff.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/file_format.py
diff --git a/tools/binary_size/libsupersize/file_format.py b/tools/binary_size/libsupersize/file_format.py
index c13f4d3b65b0bea8ad1297372a2f62c88282e919..7be9b341ebf4f1dcb723f9ffd41d7665551bff6d 100644
--- a/tools/binary_size/libsupersize/file_format.py
+++ b/tools/binary_size/libsupersize/file_format.py
@@ -45,7 +45,7 @@ def _SaveSizeInfoToFile(size_info, file_obj):
# Store a single copy of all paths and have them referenced by index.
# Using an OrderedDict makes the indices more repetitive (better compression).
path_tuples = collections.OrderedDict.fromkeys(
- (s.object_path, s.source_path) for s in size_info.symbols)
+ (s.object_path, s.source_path) for s in size_info.raw_symbols)
for i, key in enumerate(path_tuples):
path_tuples[key] = i
file_obj.write('%d\n' % len(path_tuples))
@@ -53,7 +53,7 @@ def _SaveSizeInfoToFile(size_info, file_obj):
_LogSize(file_obj, 'paths') # For libchrome, adds 200kb.
# Symbol counts by section.
- by_section = size_info.symbols.GroupedBySectionName().Sorted(
+ by_section = size_info.raw_symbols.GroupedBySectionName().Sorted(
key=lambda s:(s[0].IsBss(), s[0].address, s.full_name))
file_obj.write('%s\n' % '\t'.join(g.name for g in by_section))
file_obj.write('%s\n' % '\t'.join(str(len(g)) for g in by_section))
« no previous file with comments | « tools/binary_size/libsupersize/diff.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698