Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2884283002: supersize: Fix diff logic for changed vs unchanged of groups (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Fix diff logic for changed vs unchanged of groups It wasn't correct when subgroups had aliases that were removed. Tests are updated to add coverage for this case. BUG=681694 Review-Url: https://codereview.chromium.org/2884283002 Cr-Commit-Position: refs/heads/master@{#472133} Committed: https://chromium.googlesource.com/chromium/src/+/ac5c9698111bcb9e65b291dcf35755c9f72a2517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -81 lines) Patch
M tools/binary_size/diagnose_bloat.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/binary_size/libsupersize/describe.py View 5 chunks +37 lines, -32 lines 0 comments Download
M tools/binary_size/libsupersize/integration_test.py View 4 chunks +17 lines, -6 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 5 chunks +52 lines, -36 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 1 chunk +3 lines, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/16 15:24:00, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🥊
3 years, 7 months ago (2017-05-16 15:24:12 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-16 16:39:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884283002/1
3 years, 7 months ago (2017-05-16 16:47:33 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 17:01:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac5c9698111bcb9e65b291dcf357...

Powered by Google App Engine
This is Rietveld 408576698