Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/binary_size/libsupersize/testdata/Console.golden

Issue 2885073002: supersize: Move [clone] from name -> flags & rewrite Cluster() (Closed)
Patch Set: review comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/binary_size/libsupersize/testdata/Console.golden
diff --git a/tools/binary_size/libsupersize/testdata/Console.golden b/tools/binary_size/libsupersize/testdata/Console.golden
index b2fcf514e0b52c879e9d50eae507111a05ce4216..f4a62b6da40b94d2f0d1866d943d94e93aafa091 100644
--- a/tools/binary_size/libsupersize/testdata/Console.golden
+++ b/tools/binary_size/libsupersize/testdata/Console.golden
@@ -1,10 +1,10 @@
********************************************************************************
Entering interactive Python shell. Quick reference:
-SizeInfo: Clustered, metadata, raw_symbols, section_sizes, symbols
+SizeInfo: metadata, raw_symbols, section_sizes, symbols
Symbol: FlagsString, IsBss, IsGeneratedByToolchain, IsGroup, address, aliases, end_address, flags, full_name, generated_source, is_anonymous, name, num_aliases, object_path, padding, pss, pss_without_padding, section, section_name, size, size_without_padding, source_path, template_name
-SymbolGroup (extends Symbol): Clustered, CountUniqueSymbols, Filter, GroupedBy, GroupedByName, GroupedByPath, GroupedBySectionName, Inverted, IterLeafSymbols, IterUniqueSymbols, Sorted, SortedByAddress, SortedByCount, SortedByName, WhereAddressInRange, WhereFullNameMatches, WhereGeneratedByToolchain, WhereHasAnyAttribution, WhereHasPath, WhereInSection, WhereIsTemplate, WhereMatches, WhereNameMatches, WhereObjectPathMatches, WherePathMatches, WherePssBiggerThan, WhereSizeBiggerThan, WhereSourceIsGenerated, WhereSourcePathMatches, WhereTemplateNameMatches, is_sorted
+SymbolGroup (extends Symbol): CountUniqueSymbols, Filter, GroupedBy, GroupedByName, GroupedByPath, GroupedBySectionName, Inverted, IterLeafSymbols, IterUniqueSymbols, Sorted, SortedByAddress, SortedByCount, SortedByName, WhereAddressInRange, WhereFullNameMatches, WhereGeneratedByToolchain, WhereHasAnyAttribution, WhereHasPath, WhereInSection, WhereIsGroup, WhereIsTemplate, WhereMatches, WhereNameMatches, WhereObjectPathMatches, WherePathMatches, WherePssBiggerThan, WhereSizeBiggerThan, WhereSourceIsGenerated, WhereSourcePathMatches, WhereTemplateNameMatches, is_sorted
SymbolDiff (extends SymbolGroup): DiffStatus, IsAdded, IsChanged, IsRemoved, IsUnchanged, WhereNotUnchanged, added_count, changed_count, removed_count, unchanged_count
@@ -42,7 +42,7 @@ Print(Diff(size_info1, size_info2), to_file="output.txt")
# View per-component breakdowns, then drill into the last entry.
c = canned_queries.CategorizeByChromeComponent()
Print(c)
-Print(c[-1].GroupedByPath(depth=2).Clustered().Sorted())
+Print(c[-1].GroupedByPath(depth=2).Sorted())
# For even more inspiration, look at canned_queries.py
# (and feel free to add your own!).
@@ -64,7 +64,7 @@ Section Sizes (Total=41.8mb (43785380 bytes)):
.rodata: 5.65mb (5927652 bytes) (13.5%)
.text: 34.2mb (35900712 bytes) (82.0%)
-Showing 49 symbols (46 unique) with total pss: 43785380 bytes
+Showing 44 symbols (43 unique) with total pss: 43785380 bytes
.text=34.2mb .rodata=5.65mb .data*=1.87mb .bss=512kb total=41.8mb
Number of unique paths: 9
@@ -80,90 +80,80 @@ Index, Running Total, Section@Address, PSS
extFromUUseMapping
4) 170 (0.0%) t@0x28d98a 32 base/page_allocator.cc
extFromUUseMapping
-5) 5888 (0.0%) t@0x28f000 5718 {no path}
- ** symbol gap 0
-6) 6336 (0.0%) t@0x28f000 448 third_party/icu/ucnv_ext.c
+5) 35830930 (81.8%) t@Group 35830760 {no path}
+ ** symbol gaps (count=3)
+6) 35831378 (81.8%) t@0x28f000 448 third_party/icu/ucnv_ext.c
ucnv_extMatchFromU
-7) 6364 (0.0%) t@0x28f1c8 28 third_party/icu/ucnv_ext.c
+7) 35831406 (81.8%) t@0x28f1c8 28 third_party/icu/ucnv_ext.c
_GLOBAL__sub_I_SkDeviceProfile.cpp
-8) 75488 (0.2%) t@0x28f1e0 69124 third_party/icu/ucnv_ext.c
+8) 35900530 (82.0%) t@0x28f1e0 69124 third_party/icu/ucnv_ext.c
foo_bar
-9) 75512 (0.2%) t@0x2a0000 24 {no path}
- blink::ContiguousContainerBase::shrinkToFit
-10) 75536 (0.2%) t@0x2a0000 24 third_party/icu/ucnv_ext.c
+9) 35900558 (82.0%) t@Group 28 {no path}
+ blink::ContiguousContainerBase::shrinkToFit (count=2)
+10) 35900582 (82.0%) t@0x2a0000 24 third_party/icu/ucnv_ext.c
BazAlias
-11) 75540 (0.2%) t@0x2a0010 4 third_party/{shared}/2
- blink::ContiguousContainerBase::shrinkToFit [clone .part.1234] [clone .isra.2]
-12) 75544 (0.2%) t@0x2a0010 4 third_party/fft_float.cc
+11) 35900586 (82.0%) t@0x2a0010 4 third_party/fft_float.cc
FooAlias
-13) 75548 (0.2%) t@0x2a0010 4 third_party/fft_float.cc
+12) 35900590 (82.0%) t@0x2a0010 4 third_party/fft_float.cc
BarAlias
-14) 75576 (0.2%) t@0x2a0020 28 third_party/container.c
+13) 35900618 (82.0%) t@0x2a0020 28 third_party/container.c
blink::ContiguousContainerBase::ContiguousContainerBase
-15) 79616 (0.2%) t@0x2a1000 4040 {no path}
- ** symbol gap 1
-16) 79710 (0.2%) t@0x2a1000 94 third_party/container.c
- blink::PaintChunker::releasePaintChunks [clone .part.1]
-17) 35900712 (82.0%) t@0x24ca628 35821002 {no path}
- ** symbol gap 2 (end of section)
-18) 37862696 (86.5%) r@0x266e600 1961984 {no path}
- ** merge strings
-19) 37866121 (86.5%) r@0x284d600 3425 {no path}
+14) 35900712 (82.0%) t@0x2a1000 94 third_party/container.c
+ blink::PaintChunker::releasePaintChunks
+15) 38538681 (88.0%) r@Group 2637969 {no path}
+ ** merge strings (count=2)
+16) 38542106 (88.0%) r@0x284d600 3425 {no path}
** merge constants
-20) 37866124 (86.5%) r@0x284e364 3 {no path}
- ** symbol gap 0
-21) 37866132 (86.5%) r@0x284e364 8 base/page_allocator.cc
-22) 37866176 (86.5%) r@0x284e370 44 base/page_allocator.cc
+17) 41828221 (95.5%) r@Group 3286115 {no path}
+ ** symbol gaps (count=2)
+18) 41828229 (95.5%) r@0x284e364 8 base/page_allocator.cc
+19) 41828273 (95.5%) r@0x284e370 44 base/page_allocator.cc
Name
-23) 37866208 (86.5%) r@0x284e398 32 third_party/container.c
+20) 41828305 (95.5%) r@0x284e398 32 third_party/container.c
chrome::mojom::FilePatcher::Name_
-24) 38542193 (88.0%) r@0x284e518 675985 {no path}
- ** merge strings
-25) 38542248 (88.0%) r@0x28f3450 55 third_party/paint.cc
+21) 41828360 (95.5%) r@0x28f3450 55 third_party/paint.cc
kAnimationFrameTimeHistogramClassPath
-26) 38542252 (88.0%) r@0x28f3480 4 third_party/paint.cc
+22) 41828364 (95.5%) r@0x28f3480 4 third_party/paint.cc
blink::CSSValueKeywordsHash::findValueImpl::value_word_list
-27) 41828364 (95.5%) r@0x2c158e4 3286112 {no path}
- ** symbol gap 1 (end of section)
-28) 41828420 (95.5%) d@0x2c176f0 56 third_party/icu/ucnv_ext.c
+23) 41828420 (95.5%) d@0x2c176f0 56 third_party/icu/ucnv_ext.c
ChromeMainDelegate [vtable]
-29) 41828444 (95.5%) d@0x2c17728 24 third_party/icu/ucnv_ext.c
+24) 41828444 (95.5%) d@0x2c17728 24 third_party/icu/ucnv_ext.c
chrome::mojom::FieldTrialRecorder [vtable]
-30) 42618348 (97.3%) d@0x2c17740 789904 third_party/container.c
+25) 42618348 (97.3%) d@0x2c17740 789904 third_party/container.c
chrome::mojom::FieldTrialRecorderProxy [vtable]
-31) 42618380 (97.3%) d@0x2cd84e0 32 third_party/gvr-android-sdk/libgvr_shim_static_arm.a/libcontroller_api_impl.a_controller_api_impl.o
+26) 42618380 (97.3%) d@0x2cd84e0 32 third_party/gvr-android-sdk/libgvr_shim_static_arm.a/libcontroller_api_impl.a_controller_api_impl.o
.Lswitch.table.45
-32) 42618388 (97.3%) d@0x2cd84f0 8 third_party/gvr-android-sdk/libgvr_shim_static_arm.a/libport_android_jni.a_jni_utils.o
+27) 42618388 (97.3%) d@0x2cd84f0 8 third_party/gvr-android-sdk/libgvr_shim_static_arm.a/libport_android_jni.a_jni_utils.o
kSystemClassPrefixes
-33) 42618444 (97.3%) d@0x2cd8500 56 third_party/paint.cc
+28) 42618444 (97.3%) d@0x2cd8500 56 third_party/paint.cc
ChromeMainDelegateAndroid [vtable]
-34) 42618468 (97.3%) d@0x2cd8538 24 base/page_allocator.cc
+29) 42618468 (97.3%) d@0x2cd8538 24 base/page_allocator.cc
mojo::MessageReceiver [vtable]
-35) 42618480 (97.3%) d@0x2cd8550 12 base/page_allocator.cc
+30) 42618480 (97.3%) d@0x2cd8550 12 base/page_allocator.cc
kMethodsAnimationFrameTimeHistogram
-36) 43683612 (99.8%) d@0x2ddc608 1065132 {no path}
+31) 43683612 (99.8%) d@0x2ddc608 1065132 {no path}
** symbol gap 0 (end of section)
-37) 43683616 (99.8%) d@0x2de7000 4 base/page_allocator.cc
+32) 43683616 (99.8%) d@0x2de7000 4 base/page_allocator.cc
google::protobuf::internal::pLinuxKernelCmpxchg
-38) 43683620 (99.8%) d@0x2de7004 4 third_party/container.c
+33) 43683620 (99.8%) d@0x2de7004 4 third_party/container.c
google::protobuf::internal::pLinuxKernelMemoryBarrier
-39) 43683772 (99.8%) d@0x2de7008 152 third_party/container.c
+34) 43683772 (99.8%) d@0x2de7008 152 third_party/container.c
base::android::kBaseRegisteredMethods
-40) 43683776 (99.8%) d@0x2de70a0 4 third_party/container.c
+35) 43683776 (99.8%) d@0x2de70a0 4 third_party/container.c
base::android::g_renderer_histogram_code
-41) 43683780 (99.8%) d@0x2de70a4 4 third_party/container.c
+36) 43683780 (99.8%) d@0x2de70a4 4 third_party/container.c
base::android::g_library_version_number
-42) 43785380 (100.0%) d@0x2dffd88 101600 {no path}
+37) 43785380 (100.0%) d@0x2dffd88 101600 {no path}
** symbol gap 0 (end of section)
-43) 43785380 (100.0%) b@0x0 262144 third_party/fft_float.cc
+38) 43785380 (100.0%) b@0x0 262144 third_party/fft_float.cc
ff_cos_131072
-44) 43785380 (100.0%) b@0x0 131072 third_party/fft_fixed.cc
+39) 43785380 (100.0%) b@0x0 131072 third_party/fft_fixed.cc
ff_cos_131072_fixed
-45) 43785380 (100.0%) b@0x0 131072 third_party/fft_float.cc
+40) 43785380 (100.0%) b@0x0 131072 third_party/fft_float.cc
ff_cos_65536
-46) 43785380 (100.0%) b@0x2dffda0 28 third_party/icu/ucnv_ext.c
+41) 43785380 (100.0%) b@0x2dffda0 28 third_party/icu/ucnv_ext.c
g_chrome_content_browser_client
-47) 43785380 (100.0%) b@0x2dffe80 200 third_party/icu/ucnv_ext.c
+42) 43785380 (100.0%) b@0x2dffe80 200 third_party/icu/ucnv_ext.c
SaveHistogram::atomic_histogram_pointer
-48) 43785380 (100.0%) b@0x2dffe84 4 third_party/icu/ucnv_ext.c
+43) 43785380 (100.0%) b@0x2dffe84 4 third_party/icu/ucnv_ext.c
g_AnimationFrameTimeHistogram_clazz

Powered by Google App Engine
This is Rietveld 408576698