Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2888693002: supersize: Add Print(idx). Sort subgroups in canned_queries. (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Add Print(idx). Sort subgroups in canned_queries. BUG=681694 Review-Url: https://codereview.chromium.org/2888693002 Cr-Commit-Position: refs/heads/master@{#472219} Committed: https://chromium.googlesource.com/chromium/src/+/80107cbb98e36605e9aece1c43251d1e0982e0d5

Patch Set 1 #

Patch Set 2 : supersize: Add Print(idx). Sort subgroups in canned_queries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M tools/binary_size/libsupersize/canned_queries.py View 1 3 chunks +8 lines, -5 lines 0 comments Download
M tools/binary_size/libsupersize/console.py View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/16 19:44:22, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🎳
3 years, 7 months ago (2017-05-16 19:44:30 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-16 19:53:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888693002/20001
3 years, 7 months ago (2017-05-16 19:55:48 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 21:11:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80107cbb98e36605e9aece1c4325...

Powered by Google App Engine
This is Rietveld 408576698