tools/binary_size/libsupersize/describe.py - Issue 2885073002: supersize: Move [clone] from name -> flags & rewrite Cluster()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/libsupersize/describe.py

Issue 2885073002: supersize: Move [clone] from name -> flags & rewrite Cluster() (Closed)

Patch Set: review comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/binary_size/libsupersize/describe.py

diff --git a/tools/binary_size/libsupersize/describe.py b/tools/binary_size/libsupersize/describe.py

index 78a91e066dcfaa3a1c05a0bc68fc49c9f3dc7c8e..19dd0640b7d43cd6fff30514e3746bf922611bc0 100644

--- a/tools/binary_size/libsupersize/describe.py

+++ b/tools/binary_size/libsupersize/describe.py

@@ -276,9 +276,7 @@ def DescribeSizeInfoCoverage(size_info):

expected_size = size_info.section_sizes[

models.SECTION_TO_SECTION_NAME[section]]

- # Use raw_symbols in case symbols contains groups.

- in_section = models.SymbolGroup(size_info.raw_symbols).WhereInSection(

- section)

+ in_section = size_info.raw_symbols.WhereInSection(section)

actual_size = in_section.size

size_percent = _Divide(actual_size, expected_size)

yield ('Section {}: has {:.1%} of {} bytes accounted for from '

« no previous file with comments | « tools/binary_size/libsupersize/console.py ('k') | tools/binary_size/libsupersize/diff.py » ('j') | no next file with comments »