Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
Mike West, *fs
CC:
fs, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, gyuyoung2, haraken, Justin Novosad, kenneth.christiansen, kinuko+watch, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, Yoav Weiss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Rename blink::ColorSpace to blink::InterpolationSpace blink::ColorSpace is used to specify in which space to perform pixel value interpolation. Change the name to reflect that. We use gfx::ColorSpace and SkColorSpace for true color spaces. BUG=722612 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2884313002 Cr-Commit-Position: refs/heads/master@{#472645} Committed: https://chromium.googlesource.com/chromium/src/+/b8a4655d6d92c49853dc1d395d09d7cf86777d84

Patch Set 1 #

Total comments: 10

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -516 lines) Patch
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaValuesCached.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 5 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/graphics/ColorSpace.h View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/ColorSpace.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp View 1 1 chunk +68 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/InterpolationSpace.h View 1 1 chunk +26 lines, -40 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/InterpolationSpace.cpp View 5 chunks +19 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h View 5 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/PaintFilterEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h View 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 4 chunks +31 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (18 generated)
ccameron
ptal -- simple search-replace
3 years, 7 months ago (2017-05-16 16:50:09 UTC) #3
Mike West
Happy to stamp the mechanical change, but I'm not a good person to ask about ...
3 years, 7 months ago (2017-05-17 07:01:55 UTC) #10
Mike West
(rs LGTM)
3 years, 7 months ago (2017-05-17 07:02:09 UTC) #11
fs
lgtm https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp File third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp (right): https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp#newcode1 third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp:1: #include "platform/graphics/ColorSpaceGamut.h" Ditto. https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.h File third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.h (right): https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.h#newcode1 ...
3 years, 7 months ago (2017-05-17 11:54:59 UTC) #12
ccameron
Thanks! https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp File third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp (right): https://codereview.chromium.org/2884313002/diff/1/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp#newcode1 third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp:1: #include "platform/graphics/ColorSpaceGamut.h" On 2017/05/17 11:54:58, fs wrote: > ...
3 years, 7 months ago (2017-05-17 19:05:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884313002/20001
3 years, 7 months ago (2017-05-17 19:06:59 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457924)
3 years, 7 months ago (2017-05-17 21:44:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884313002/20001
3 years, 7 months ago (2017-05-17 22:04:32 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:44:46 UTC) #27
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8a4655d6d92c49853dc1d395d09...

Powered by Google App Engine
This is Rietveld 408576698