third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

index 9af5a7231c8809b1214b767b46bdffe68ea7e1ed..bb0bd07fecfe36a5e8a1339a467249e036a96d0d 100644

--- a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

@@ -83,11 +83,11 @@ bool SVGFilterPrimitiveStandardAttributes::SetFilterEffectAttribute(

DCHECK(GetLayoutObject());

EColorInterpolation color_interpolation =

GetLayoutObject()->StyleRef().SvgStyle().ColorInterpolationFilters();

- ColorSpace resolved_color_space =

- SVGFilterBuilder::ResolveColorSpace(color_interpolation);

- if (resolved_color_space == effect->OperatingColorSpace())

+ InterpolationSpace resolved_interpolation_space =

+ SVGFilterBuilder::ResolveInterpolationSpace(color_interpolation);

+ if (resolved_interpolation_space == effect->OperatingInterpolationSpace())

return false;

- effect->SetOperatingColorSpace(resolved_color_space);

+ effect->SetOperatingInterpolationSpace(resolved_interpolation_space);

return true;

}