third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEFlood.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

index baabc743ee1245c607177f948d23b68e0ad9f411..96dabb9e5b5d85af5bda56bec3c7bd76491c13f9 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

@@ -75,13 +75,13 @@ FloatRect FEDropShadow::MapEffect(const FloatRect& rect) const {

}

sk_sp<SkImageFilter> FEDropShadow::CreateImageFilter() {

- sk_sp<SkImageFilter> input(

- SkiaImageFilterBuilder::Build(InputEffect(0), OperatingColorSpace()));

+ sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::Build(

+ InputEffect(0), OperatingInterpolationSpace()));

float dx = GetFilter()->ApplyHorizontalScale(dx_);

float dy = GetFilter()->ApplyVerticalScale(dy_);

float std_x = GetFilter()->ApplyHorizontalScale(std_x_);

float std_y = GetFilter()->ApplyVerticalScale(std_y_);

- Color color = AdaptColorToOperatingColorSpace(

+ Color color = AdaptColorToOperatingInterpolationSpace(

shadow_color_.CombineWithAlpha(shadow_opacity_));

SkImageFilter::CropRect crop_rect = GetCropRect();

return SkDropShadowImageFilter::Make(