third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp b/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

index 5139b4626e2621d64e264d20d6647de9f88a1ffa..8cc689e4230d2690fbb4a3c49ee7f51d16fb9c76 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

@@ -35,13 +35,13 @@ SourceAlpha* SourceAlpha::Create(FilterEffect* source_effect) {

SourceAlpha::SourceAlpha(FilterEffect* source_effect)

: FilterEffect(source_effect->GetFilter()) {

- SetOperatingColorSpace(source_effect->OperatingColorSpace());

+ SetOperatingInterpolationSpace(source_effect->OperatingInterpolationSpace());

InputEffects().push_back(source_effect);

}

sk_sp<SkImageFilter> SourceAlpha::CreateImageFilter() {

- sk_sp<SkImageFilter> source_graphic(

- SkiaImageFilterBuilder::Build(InputEffect(0), OperatingColorSpace()));

+ sk_sp<SkImageFilter> source_graphic(SkiaImageFilterBuilder::Build(

+ InputEffect(0), OperatingInterpolationSpace()));

SkScalar matrix[20] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

0, 0, 0, 0, 0, 0, 0, 0, SK_Scalar1, 0};

sk_sp<SkColorFilter> color_filter =